Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add support for external accounts in detect #8508

Merged
merged 13 commits into from
Sep 6, 2023
Merged

feat(auth): add support for external accounts in detect #8508

merged 13 commits into from
Sep 6, 2023

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 29, 2023

This is a direct followup to #8491 and adds the last part of the detect package; external account support.

@codyoss
feat(auth): add support for external accounts in detect
a9a5682 
This is a direct followup to googleapis#8491 and adds the last part of the
detect package; external account support.
@codyoss codyoss requested a review from a team as a code owner August 29, 2023 21:12
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Aug 29, 2023
noahdietz
noahdietz reviewed Aug 30, 2023
View reviewed changes
auth/detect/internal/externalaccount/awsprovider.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/awsprovider.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/awsprovider.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/awsprovider.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/awsprovider.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/executableprovider.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/externalaccount.go Show resolved Hide resolved
auth/detect/internal/externalaccount/externalaccount.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/fileprovider.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/urlprovider.go Outdated Show resolved Hide resolved
quartzmo
quartzmo approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a couple of docs nits.

auth/detect/internal/externalaccount/externalaccount.go Outdated Show resolved Hide resolved
auth/detect/internal/externalaccount/externalaccount.go Outdated Show resolved Hide resolved
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
@codyoss codyoss merged commit 62210d5 into googleapis:main Sep 6, 2023
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
@codyoss codyoss deleted the auth3 branch September 6, 2023 18:30
This was referenced Sep 6, 2023
Merged
Merged
@codyoss codyoss mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codyoss @quartzmo @noahdietz