feat(auth): add httptransport package #8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is the equivalent of google.golang.org/api/transport/http for the new auth library. The biggest different is the main function does not return an endpoint so we will want to add a helper in gax or somewhere for this. Also, there are is an extra helper to add a TokenProvider to a http.Client which should elveate some user needs for extra extenisablity of a client. They can simply customize away and user the helper to add auth.
codyoss
added a commit
to codyoss/google-cloud-go
that referenced
this pull request
Sep 13, 2023
quartzmo
reviewed
Sep 13, 2023
quartzmo
reviewed
Sep 13, 2023
noahdietz
reviewed
Sep 13, 2023
quartzmo
approved these changes
Sep 13, 2023
noahdietz
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is the equivalent of
google.golang.org/api/transport/http for the new auth library. The biggest different is the main function does not return an endpoint so we will want to add a helper in gax or somewhere for this. Also, there are is an extra helper to add a TokenProvider to a http.Client which should elveate some user needs for extra extenisablity of a client. They can simply customize away and user the helper to add auth.
This PR is part 1 of 2 to make it easier to review. Took away anything dealing with certs/tls for now and will fast follow and comment back in some of the code in this PR.