feat(auth): add cert support to httptransport #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
reviewed
Sep 15, 2023
noahdietz
approved these changes
Sep 15, 2023
quartzmo
requested changes
Sep 15, 2023
There was a problem hiding this comment.
At a high level, i'm wondering if cba.go could be split into two or more files, in order to isolate S2A code from default transport, etc. The litmus test for this would be to imagine removing the S2A code later and having it be very easy to do. But the reason is not just to make it easier to remove S2A, but also to make it easier to understand.
quartzmo
approved these changes
Sep 19, 2023
codyoss
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #8567