Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add impersonate package #8578

Merged
merged 5 commits into from
Sep 15, 2023
Merged

feat(auth): add impersonate package #8578

merged 5 commits into from
Sep 15, 2023

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 15, 2023

No description provided.

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Sep 15, 2023
@codyoss codyoss marked this pull request as ready for review September 15, 2023 14:42
@codyoss codyoss requested a review from a team as a code owner September 15, 2023 14:42
noahdietz
noahdietz reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits/questions

auth/impersonate/example_test.go Show resolved Hide resolved
auth/impersonate/idtoken.go Outdated Show resolved Hide resolved
auth/impersonate/idtoken.go Outdated Show resolved Hide resolved
auth/impersonate/idtoken.go Outdated Show resolved Hide resolved
auth/impersonate/impersonate.go Outdated Show resolved Hide resolved
auth/impersonate/impersonate.go Outdated Show resolved Hide resolved
auth/impersonate/impersonate.go Outdated Show resolved Hide resolved
auth/impersonate/user.go Outdated Show resolved Hide resolved
auth/impersonate/user.go Outdated Show resolved Hide resolved
auth/impersonate/user.go Outdated Show resolved Hide resolved
quartzmo
quartzmo requested changes Sep 15, 2023
View reviewed changes
auth/impersonate/idtoken.go Outdated Show resolved Hide resolved
auth/impersonate/idtoken.go Outdated Show resolved Hide resolved
auth/impersonate/example_test.go Show resolved Hide resolved
auth/impersonate/example_test.go Show resolved Hide resolved
auth/impersonate/idtoken.go Outdated Show resolved Hide resolved
auth/impersonate/idtoken.go Outdated Show resolved Hide resolved
quartzmo
quartzmo reviewed Sep 15, 2023
View reviewed changes
auth/impersonate/idtoken.go Show resolved Hide resolved
auth/impersonate/impersonate.go Show resolved Hide resolved
auth/impersonate/doc.go Show resolved Hide resolved
quartzmo
quartzmo reviewed Sep 15, 2023
View reviewed changes
auth/impersonate/user_test.go Show resolved Hide resolved
auth/impersonate/idtoken_test.go Show resolved Hide resolved
auth/impersonate/impersonate_test.go Show resolved Hide resolved
auth/impersonate/impersonate.go Outdated Show resolved Hide resolved
auth/impersonate/impersonate.go Outdated Show resolved Hide resolved
codyoss
codyoss commented Sep 15, 2023
View reviewed changes
Copy link
Member Author

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@quartzmo
Copy link
Member

Approved pending additional test assertions (if possible), thanks!

codyoss
codyoss commented Sep 15, 2023
View reviewed changes
Copy link
Member Author

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Sep 15, 2023
quartzmo
quartzmo approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@gcf-merge-on-green gcf-merge-on-green bot merged commit e29ba0c into googleapis:main Sep 15, 2023
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 15, 2023
@codyoss codyoss deleted the auth7 branch September 15, 2023 18:28
@release-please release-please bot mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codyoss @quartzmo @noahdietz