Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): support autoclass v2.1 #8721

Merged
merged 8 commits into from
Oct 30, 2023
Merged

feat(storage): support autoclass v2.1 #8721

merged 8 commits into from
Oct 30, 2023

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Oct 13, 2023

Fixes #8584

@cojenco cojenco requested review from a team as code owners October 13, 2023 22:03
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 13, 2023
@cojenco cojenco changed the title feat: support autoclass v2.1 feat(storage): support autoclass v2.1 Oct 13, 2023
@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 13, 2023
@cojenco cojenco mentioned this pull request Oct 13, 2023
Merged
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 14, 2023
tritone
tritone reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some minor stuff

storage/integration_test.go Outdated Show resolved Hide resolved
storage/bucket.go Outdated Show resolved Hide resolved
@cojenco cojenco requested a review from tritone October 16, 2023 21:17
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2023
BrennaEpp
BrennaEpp approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a couple minor questions

storage/integration_test.go Show resolved Hide resolved
storage/bucket_test.go Show resolved Hide resolved
@cojenco cojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2023
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Oct 30, 2023
@cojenco cojenco merged commit fe1e195 into googleapis:main Oct 30, 2023
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 30, 2023
@release-please release-please bot mentioned this pull request Oct 30, 2023
Merged
@noahdietz noahdietz mentioned this pull request Nov 1, 2023
Closed
bhshkh pushed a commit that referenced this pull request Nov 3, 2023
@cojenco @bhshkh
feat(storage): support autoclass v2.1 (#8721)
c099da3 
* feat: add autoclass v2.1 support

* start updating bucket_test

* update tests

* address comments and update tests var naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennaEpp BrennaEpp BrennaEpp approved these changes

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: add support for Autoclass v2.1
4 participants
@cojenco @tritone @BrennaEpp @kokoro-team