Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigtable: Allow microseconds for TimestampRangeFilter in emulator #9149

Closed
mathanv91 opened this issue Dec 13, 2023 · 0 comments · Fixed by #9414
Closed

bigtable: Allow microseconds for TimestampRangeFilter in emulator #9149

mathanv91 opened this issue Dec 13, 2023 · 0 comments · Fixed by #9414
Assignees
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mathanv91
Copy link

Is your feature request related to a problem? Please describe.

There was this issue that was raised in 2022~ regarding allowing microseconds precision for TimestampRangeFilter. It looks like this issue is relevant now since the Bigtable service is accepting these but not the Bigtable emulator.

When running this mutation which contains a TimestampRangeFilter against the Bigtable emulator for this conditional row mutation:

ConditionalRowMutation conditionalRowMutation =
              ConditionalRowMutation.create(
                      <tableName>, <key>)
                  .condition(
                      FILTERS
                          .chain()
                          .filter(
                              FILTERS.timestamp().exact(<timestamp>)))
                  .then(rowMutation);

I get the following error that I don't get when running against a Bigtable instance.

Caused by: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Error in field 'timestamp_range_filter'. Maximum precision allowed in filter is millisecond.
Got:
Start: 1702478558245000
End: 1702478558245001

Describe the solution you'd like

Allowing microseconds precision for TimestampRangeFilter as suggested from the original issue if this is allowed now.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@mathanv91 mathanv91 added the triage me I really want to be triaged. label Dec 13, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 13, 2023
@noahdietz noahdietz changed the title bigtable: Allow microseconds for TimestampRangeFilter bigtable: Allow microseconds for TimestampRangeFilter in emulator Dec 19, 2023
@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants