Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/trace: opentelemetry-go requires Go 1.20 #9267

Closed
quartzmo opened this issue Jan 16, 2024 · 2 comments · Fixed by #9268
Closed

internal/trace: opentelemetry-go requires Go 1.20 #9267

quartzmo opened this issue Jan 16, 2024 · 2 comments · Fixed by #9268
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@quartzmo
Copy link
Member

Client

Spanner

Go Environment

Go1.19

Actual behavior

From @harshachinta:

I tried to run a sample application with Go1.19 against Spanner go client library for collecting metrics and got the below error

[go.opentelemetry.io/otel/sdk/metric](https://www.google.com/url?q=http://go.opentelemetry.io/otel/sdk/metric&sa=D)
/go/pkg/mod/[go.opentelemetry.io/otel/sdk/metric@v1.21.0/meter.go:472:26](https://www.google.com/url?q=http://go.opentelemetry.io/otel/sdk/metric@v1.21.0/meter.go:472:26&sa=D): undefined: errors.Join
/go/pkg/mod/[go.opentelemetry.io/otel/sdk/metric@v1.21.0/meter.go:516:26](https://www.google.com/url?q=http://go.opentelemetry.io/otel/sdk/metric@v1.21.0/meter.go:516:26&sa=D): undefined: errors.Join
note: module requires Go 1.20
FAIL    [cloud.google.com/go/spanner/test](http://cloud.google.com/go/spanner/test) [build failed]

Additional context

This is the release that dropped the compatibility for Go 1.19
https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.18.0

google-cloud-go updated to opentelemetry-go v1.21.0 in #9230.
@quartzmo quartzmo added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Jan 16, 2024
quartzmo added a commit to quartzmo/google-cloud-go that referenced this issue Jan 16, 2024
@quartzmo
docs(main): add OpenTelemetry-Go compatibility warning to debug.md
4cf4566 
closes: googleapis#9267
@quartzmo quartzmo mentioned this issue Jan 16, 2024
Merged
@quartzmo quartzmo changed the title packagename: short description of bug internal/trace: opentelemetry-go requires Go 1.20 Jan 16, 2024
@codyoss codyoss added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 16, 2024
@codyoss
Copy link
Member

codyoss commented Jan 16, 2024

I think we should downgrade the dependency and pin it for the time being.

@quartzmo quartzmo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 17, 2024
@quartzmo
Copy link
Member Author

Do not merge pending investigation of downgrading and pinning the dependency.

quartzmo added a commit that referenced this issue Jan 22, 2024
@quartzmo
docs(main): add OpenTelemetry-Go compatibility warning to debug.md (#…
18f9bb9 
…9268)

closes: #9267
@release-please release-please bot mentioned this issue Jan 22, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 26, 2024
@release-please
chore(main): release 0.112.1 (#9253)
3ed3d54 
🤖 I have created a release *beep* *boop*
---


## [0.112.1](https://togithub.com/googleapis/google-cloud-go/compare/v0.112.0...v0.112.1) (2024-02-26)


### Bug Fixes

* **internal/postprocessor:** Handle googleapis link in commit body ([#9251](https://togithub.com/googleapis/google-cloud-go/issues/9251)) ([1dd3515](https://togithub.com/googleapis/google-cloud-go/commit/1dd35157bff871a2b3e5b0e3cac33502737fd631))


### Documentation

* **main:** Add OpenTelemetry-Go compatibility warning to debug.md ([#9268](https://togithub.com/googleapis/google-cloud-go/issues/9268)) ([18f9bb9](https://togithub.com/googleapis/google-cloud-go/commit/18f9bb94fbc239255a873b29462fc7c2eac3c0aa)), refs [#9267](https://togithub.com/googleapis/google-cloud-go/issues/9267)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(main): add OpenTelemetry-Go compatibility warning to debug.md quartzmo/google-cloud-go
2 participants
@quartzmo @codyoss