Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No monitoring.dashboard.v1.PieChart definitions #9357

Closed
bitcrshr opened this issue Feb 2, 2024 · 4 comments · Fixed by #9384
Closed

No monitoring.dashboard.v1.PieChart definitions #9357

bitcrshr opened this issue Feb 2, 2024 · 4 comments · Fixed by #9384
Assignees
Labels
api: monitoring Issues related to the Cloud Monitoring API. api: monitoring-dashboards Issues related to the Cloud Monitoring Dashboards API API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bitcrshr
Copy link

bitcrshr commented Feb 2, 2024

Is your feature request related to a problem? Please describe.
There doesn't appear to be (public) proto definitions for monitoring.dashboard.v1.PieChart, but there is documentation for it in the grpc reference. I would really like to be able to define pie charts using the dashboardpb Go package, and I'm a little lost as to why it's not included (unless this is a very new feature). I am using dashboardpb to define dashboards in a type-safe way so that I can serialize them to JSON and use them in terraform.

Describe the solution you'd like
It would be nice to have the PieChart available in dashboardpb, as well as the other missing widget types, though for my use case I'm currently only worried about PieChart.

Describe alternatives you've considered
I could fork and do it myself, but I gather that the above gRPC reference is generated from protos, and it seems like it might be duplicate work? Please let me know if this is not the case or if opening a PR containing the definitions in the googleapis repo would be helpful.

Additional context
I'm using dashboardpb version 1.17.1, which is latest at the time of writing. I've also started a discussion here in case it's more appropriate, and will close whichever is not necessary. Thank you!

@bitcrshr bitcrshr added the triage me I really want to be triaged. label Feb 2, 2024
@bitcrshr bitcrshr changed the title packagename: short description of feature request No monitoring.dashboard.v1.PieChart definitions Feb 2, 2024
@noahdietz
Copy link
Contributor

noahdietz commented Feb 5, 2024

Hi @bitcrshr it is a little tough because publishing the proto isn't our (Go client maintainer's) responsibility specifically, rather the API team's. That said, you don't need to care about our "processes", I just wanted to add a little color. I will see what I can do about getting this out for you, please hold.

In the future consider checking the Public Issue tracker for the API itself (list of cloud api trackers, Monitoring specifically) as it gives you more or less a direct line to the API team.

Regardless, thanks for the heads up

@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: monitoring-dashboards Issues related to the Cloud Monitoring Dashboards API API. api: monitoring Issues related to the Cloud Monitoring API. and removed triage me I really want to be triaged. labels Feb 5, 2024
@bitcrshr
Copy link
Author

bitcrshr commented Feb 5, 2024

Awesome! Thanks for pointing me towards those issue trackers, and we'll be sure to use the right channels in the future.

@noahdietz noahdietz linked a pull request Feb 12, 2024 that will close this issue
@noahdietz
Copy link
Contributor

Hey @bitcrshr we have the PieCharts proto now. The latest release of the monitoring module will contain this and other types. Thanks for the patience.

@bitcrshr
Copy link
Author

Thanks a bunch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. api: monitoring-dashboards Issues related to the Cloud Monitoring Dashboards API API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants