Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestore: TestIntegration_NewClientWithDatabase failed #9809

Closed
flaky-bot bot opened this issue Apr 18, 2024 · 2 comments · Fixed by #10018
Closed

firestore: TestIntegration_NewClientWithDatabase failed #9809

flaky-bot bot opened this issue Apr 18, 2024 · 2 comments · Fixed by #10018
Assignees
@codyoss
Labels
api: firestore Issues related to the Firestore API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Apr 18, 2024

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.

commit: 4070f1f
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 18, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Apr 18, 2024
@codyoss codyoss assigned codyoss and unassigned bhshkh Apr 18, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented Apr 19, 2024

Test passed for commit d44db47 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Apr 19, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented Apr 22, 2024

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

commit: 40f0692
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot reopened this Apr 22, 2024
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Apr 22, 2024
@codyoss codyoss added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 22, 2024
@codyoss codyoss mentioned this issue Apr 22, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 22, 2024
@codyoss
fix(auth/credentials): error on bad file name if explicitly set (#10018)
55beaa9 
Only want our fall-through logic to work for ADC specified behaviour, not explicit credential options.

Fixes: #9809
@release-please release-please bot mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
api: firestore Issues related to the Firestore API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(auth/credentials): error on bad file name if explicitly set codyoss/google-cloud-go
2 participants
@codyoss @bhshkh