Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(spanner): cleanup mockserver and mockclient #2414

Merged
merged 2 commits into from Jul 14, 2020
Merged

test(spanner): cleanup mockserver and mockclient #2414

merged 2 commits into from Jul 14, 2020

Conversation

hengfengli
Copy link
Contributor

@hengfengli hengfengli commented Jun 10, 2020 •
edited

Fixes #1972

@hengfengli hengfengli added api: spanner Issues related to the Spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 10, 2020
@hengfengli hengfengli self-assigned this Jun 10, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2020
@hengfengli hengfengli force-pushed the cleanup-mockserver-mockclient branch from fe8e59a to 9bcff63 Compare July 10, 2020 04:38
@hengfengli hengfengli removed the request for review from skuruppu July 10, 2020 05:01
@hengfengli hengfengli force-pushed the cleanup-mockserver-mockclient branch from d8db61d to 3e22d1a Compare July 13, 2020 02:59
@hengfengli hengfengli removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 13, 2020
@hengfengli hengfengli changed the title spanner: WIP - cleanup mockserver and mockclient test(spanner): cleanup mockserver and mockclient Jul 13, 2020
@hengfengli hengfengli force-pushed the cleanup-mockserver-mockclient branch from 3e22d1a to 3e36249 Compare July 13, 2020 03:02
olavloite
olavloite approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for doing this!

@hengfengli hengfengli merged commit fb37918 into googleapis:master Jul 14, 2020
@hengfengli hengfengli deleted the cleanup-mockserver-mockclient branch July 14, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner: clean up internal/testutil/mockserver & mockclient
3 participants
@hengfengli @olavloite @googlebot