Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): add extra field to ignore with cmp #2577

Merged
merged 2 commits into from Jul 9, 2020
Merged

fix(spanner): add extra field to ignore with cmp #2577

merged 2 commits into from Jul 9, 2020

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jul 9, 2020

This was caused by the upgrade of grpc in #2564.

Fixes: #2571

@codyoss
fix(spanner): add extra field to ignore with cmp
75a6104 
This was caused by the upgrade of grpc in #2564.

Fixes: #2571
@codyoss codyoss requested a review from skuruppu as a code owner July 9, 2020 20:44
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
tbpg
tbpg approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2020
@codyoss codyoss merged commit e493799 into googleapis:master Jul 9, 2020
@hengfengli hengfengli mentioned this pull request Jul 10, 2020
Closed
@codyoss codyoss deleted the span-fix branch September 11, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

@hengfengli hengfengli Awaiting requested review from hengfengli

@olavloite olavloite Awaiting requested review from olavloite

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner: many tests failed
4 participants
@codyoss @tbpg @googlebot @kokoro-team