feat(profiler): update proftest to support parsing floating-point backoff durations #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jqll
approved these changes
Jul 13, 2020
kalyanac
reviewed
Jul 13, 2020
nolanmar511
force-pushed
the
backoff-float
branch
from
0c26c7b
to
21d783d
Compare
kalyanac
approved these changes
Jul 13, 2020
tbpg
suggested changes
Jul 13, 2020
nolanmar511
force-pushed
the
backoff-float
branch
from
21d783d
to
2ba52f4
Compare
tbpg
approved these changes
Jul 14, 2020
tbpg
added
the
automerge
tbpg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first duration string in the Python profiling agent's backoff log messages has the form "2400.000s". This change allows the backoff durations to be parsed correctly for the Python agent.
TESTED: I originally tested this change by trying to parse exact log message printed by the python agent in the unit test, then simplified the unit test.