fix(pubsub): fix ordering key integration tests #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
hongalex
added
the
do not merge
hongalex
removed
the
do not merge
tbpg
suggested changes
Sep 2, 2020
tbpg
approved these changes
Sep 2, 2020
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This was referenced Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests were previously skipped due to repeated test failures.
TestIntegration_OrderedKeys_JSONfailed due to failure to use regional endpoints.TestIntegration_OrderedKeys_ResumePublishhad an issue with setting the read-only fieldID. In addition, the test message size used to induce failures was too big, causing the machines to run out of memory.This closes #2811, closes #1833, closes #1834, closes #1835, closes #1836, closes #1837, closes #1838, closes #1839, closes #1841, closes #1842, closes #1843, closes #1844