Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spansql): parse path expressions #2924

Merged
merged 1 commit into from Sep 28, 2020
Merged

feat(spanner/spansql): parse path expressions #2924

merged 1 commit into from Sep 28, 2020

Conversation

dsymonds
Copy link
Contributor

These are not properly documented, so this only attempts to support a
limited but widely used subset, which will be sufficient for more fully
supporting aliases and joins.

Updates #2462.
Updates #2463.
Updates #2850.

@dsymonds dsymonds added the api: spanner Issues related to the Spanner API. label Sep 26, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2020
@dsymonds
Copy link
Contributor Author

/cc @adg

olavloite
olavloite approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spanner/spansql/parser.go Outdated Show resolved Hide resolved
@dsymonds
feat(spanner/spansql): parse path expressions
4d7049f 
These are not properly documented, so this only attempts to support a
limited but widely used subset, which will be sufficient for more fully
supporting aliases and joins.

Updates #2462.
Updates #2463.
Updates #2850.
@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7ca409b into googleapis:master Sep 28, 2020
@dsymonds dsymonds deleted the spansql-join branch September 28, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsymonds @olavloite