Hack: Trap nil res.Row and raise an error so higher layers can retry.

[whitaker]

This happens occasionally but regularly and w/o this hack triggers
a panic when res.Row.Families is dereferenced. I don't think this
seems normal but haven't been able to identify the root cause.
However, retrying seems to be correct because I'm not seeing
duplicate writes after this error is caught + retried.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[jba]

cc @garye

[twmb]

Note that only res.Rows can be nil in the code, which would result from an empty bit of rows from the rpc response.

[garye]

@twmb @whitaker This has been close twice, is it supposed to be an open pull request? We can discuss here but move to gerrit to actually make a change (see CONTRIBUTING.md).

[whitaker]

@garye: Sorry I was opening a PR under the Fastly repo's fork but accidentally based it off here. I closed immediately but looks like @jba later found it and CC'd you.

It's a real issue I'm patching over but the current fix is only a workaround, so I wouldn't expect you to accept it. I think that means this PR should be closed and we can follow up with a fix for the root cause once it's identified & tested.

[garye]

Ok, sounds good. Let me know if you make any more progress.

On Mon, Sep 19, 2016, 8:23 PM Brad Whitaker notifications@github.com
wrote:

@garye https://github.com/garye: Sorry I was opening a PR under the
Fastly repo's fork but accidentally based it off here. I closed immediately
but looks like @jba https://github.com/jba later found it and CC'd you.

It's a real issue I'm patching over but the current fix is only a
workaround, so I wouldn't expect you to accept it. I think that means this
PR should be closed and we can follow up with a fix for the root cause once
it's identified & tested.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#376 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACTr4dhhiA90jvT2BveN0AGznU-Ilhmks5qrydxgaJpZM4KA_P6
.