feat(bigquery): export HivePartitioningOptions in load job configurations #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
hongalex
approved these changes
Apr 1, 2021
shollyman
changed the title
Weird that the conventional commit bot didn't seem to have issue with it. Updated. |
I think it just checks for the presence of any word before the colon, which the original go commit format satisfies |
shollyman
changed the title
tbpg
suggested changes
Apr 2, 2021
bigquery/load.go
Outdated
| @@ -111,6 +118,9 @@ func bqToLoadConfig(q *bq.JobConfiguration, c *Client) *LoadConfig { | |||
| fc = &s.FileConfig | |||
| lc.Src = s | |||
| } | |||
| if q.Load.HivePartitioningOptions != nil { | |||
There was a problem hiding this comment.
Looks like this still needs an update?
| RequirePartitionFilter: true, | ||
| }, | ||
| }, | ||
| want: func() *bq.Job { |
There was a problem hiding this comment.
You have no idea how much I wish we weren't in the business of mapping back and forth to discovery representations for complex resources like job configs.
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
tbpg
suggested changes
Apr 2, 2021
bigquery/load.go
Outdated
| @@ -111,6 +118,9 @@ func bqToLoadConfig(q *bq.JobConfiguration, c *Client) *LoadConfig { | |||
| fc = &s.FileConfig | |||
| lc.Src = s | |||
| } | |||
| if q.Load.HivePartitioningOptions != nil { | |||
There was a problem hiding this comment.
Looks like this still needs an update?
tbpg
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3876