Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): retry io.ErrUnexpectedEOF #3957

Merged
merged 2 commits into from Apr 19, 2021
Merged

Conversation

@tritone
Copy link
Collaborator

@tritone tritone commented Apr 17, 2021

This error can be caused by network flakiness. We already retry
it in the apiary client logic for uploads, so we should retry
here as well.

Apiary logic is here: https://github.com/googleapis/google-api-go-client/blob/master/internal/gensupport/resumable.go#L240

This error can be caused by network flakiness. We already retry
it in the apiary client logic for uploads, so we should retry
here as well.
@tritone tritone requested a review from Apr 17, 2021
@tritone tritone requested a review from as a code owner Apr 17, 2021
@google-cla google-cla bot added the cla: yes label Apr 17, 2021
tbpg
tbpg approved these changes Apr 19, 2021
storage/go110.go Show resolved Hide resolved
Loading
@tritone tritone merged commit f6590cd into googleapis:master Apr 19, 2021
3 checks passed
Loading
@tritone tritone deleted the unexpected-eof branch Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants