Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(firestore): add additional test verifying deleting a map value via update #4026

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

crwilcox
Copy link
Contributor

Demonstrate no reproduction for #3889

@crwilcox crwilcox requested review from tritone and a team as code owners April 29, 2021 19:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2021
@crwilcox crwilcox changed the title test: add additional test verifying deleting a map value via update test(firestore): add additional test verifying deleting a map value via update Apr 29, 2021
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding coverage for this case.

@crwilcox crwilcox merged commit aab30c6 into googleapis:master Apr 29, 2021
@crwilcox crwilcox deleted the verify-map-value-delete branch October 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants