Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: fix integration test #4058

Merged
merged 2 commits into from May 5, 2021
Merged

Conversation

nolanmar511
Copy link
Contributor

This change switches to using go modules consistently and switches to pulling profiler agent from https://github.com/googleapis/google-cloud-go.git rather than https://code.googlesource.com/gocloud.

TESTED= When running e2e test with go1.12, there were failures before this change and no failure with this change.

@nolanmar511 nolanmar511 requested a review from a team as a code owner May 4, 2021 23:28
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the Cloud Profiler API. label May 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2021
@nolanmar511 nolanmar511 requested a review from wyk9787 May 4, 2021 23:28
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolanmar511 nolanmar511 merged commit c760858 into googleapis:master May 5, 2021
@nolanmar511 nolanmar511 deleted the use-mods branch May 5, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the Cloud Profiler API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants