Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub/pstest): add ability to create a pstest server listening on a specified port #4459

Merged
merged 1 commit into from Jul 19, 2021

Conversation

@caod123
Copy link
Contributor

@caod123 caod123 commented Jul 19, 2021

In some of our tests we handle port allocations manually and would prefer to pass in an allocated port for our pstest Server dependency rather than having the pstest.NewServer call allocate an available port.

@google-cla
Copy link

@google-cla google-cla bot commented Jul 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 19, 2021
@caod123
Copy link
Contributor Author

@caod123 caod123 commented Jul 19, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 19, 2021
pubsub/pstest/fake.go Show resolved Hide resolved
Copy link
Member

@hongalex hongalex left a comment

LGTM pending tests

a specified port

Signed-off-by: Danny Cao <caoxiaohua@gmail.com>
@dc185333
Copy link

@dc185333 dc185333 commented Jul 19, 2021

Rebased on master, may need to force-run kokoro again

@hongalex hongalex merged commit f1b7c8b into googleapis:master Jul 19, 2021
4 checks passed
@hongalex
Copy link
Member

@hongalex hongalex commented Jul 19, 2021

Thanks for the fix @dc185333, merged.

gcf-merge-on-green bot pushed a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants