Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spansql/spantest): support CREATE | DROP VIEW #4937

Merged
merged 2 commits into from
Oct 5, 2021
Merged

feat(spansql/spantest): support CREATE | DROP VIEW #4937

merged 2 commits into from
Oct 5, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Oct 1, 2021 •
edited

Adds support for CREATE [OR REPLACE] VIEW and DROP VIEW statements.

This PR does not add support for using views in queries.

Fixes #4922

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
@olavloite olavloite marked this pull request as ready for review October 1, 2021 11:37
@olavloite olavloite requested review from hengfengli, skuruppu and a team as code owners October 1, 2021 11:37
@olavloite olavloite changed the title [WIP] feat: support CREATE | DROP VIEW feat: support CREATE | DROP VIEW Oct 1, 2021
@hengfengli hengfengli changed the title feat: support CREATE | DROP VIEW feat(spansql/spantest): support CREATE | DROP VIEW Oct 5, 2021
@hengfengli hengfengli added the api: spanner Issues related to the Spanner API. label Oct 5, 2021
hengfengli
hengfengli approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@olavloite olavloite merged commit 7b242bd into master Oct 5, 2021
@olavloite olavloite deleted the spansql-views branch October 5, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner/spansql: support for views
2 participants
@olavloite @hengfengli