Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(spanner): fix flaky TestIntegration_StartBackupOperation test #4978

Merged
merged 2 commits into from
Oct 12, 2021
Merged

test(spanner): fix flaky TestIntegration_StartBackupOperation test #4978

merged 2 commits into from
Oct 12, 2021

Conversation

rahul2393
Copy link
Contributor

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Oct 12, 2021
@hengfengli
Copy link
Contributor

hengfengli commented Oct 12, 2021 •
edited

@rahul2393 Can we also add some logs, like what you did in samples, to see how much time the create_backup operation would usually take?

@rahul2393
Copy link
Contributor Author

@rahul2393 Can we also add some logs, like what you did in samples, to see how much time the create_backup operation would usually take?

Done @hengfengli

@hengfengli hengfengli changed the title fix(spanner): fix flaky TestIntegration_StartBackupOperation test test(spanner): fix flaky TestIntegration_StartBackupOperation test Oct 12, 2021
@hengfengli hengfengli merged commit d28ba78 into googleapis:master Oct 12, 2021
@rahul2393 rahul2393 mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner: TestIntegration_StartBackupOperation failed
2 participants
@rahul2393 @hengfengli