Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spannertest): support JSON_VALUE function #5173

Merged
merged 2 commits into from Nov 29, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 26, 2021

Adds support for the JSON_VALUE function. The function always returns an empty string,
as there is no XPath query engine available in the Spanner client library. This does
however enable the usage of computed columns that use the function.

This change also fixes the TODO that generated columns cannot be added to non-empty
tables.

Fixes #5167

Adds support for the JSON_VALUE function. The function always returns an empty string,
as there is no XPath query engine available in the Spanner client library. This does
however enable the usage of computed columns that use the function.

This change also fixes the TODO that generated columns cannot be added to non-empty
tables.

Fixes #5167
@olavloite olavloite requested review from hengfengli and rahul2393 Nov 26, 2021
@olavloite olavloite requested review from skuruppu and a team as code owners Nov 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2021
Copy link
Contributor

@rahul2393 rahul2393 left a comment

LGTM

@hengfengli hengfengli changed the title feat: support JSON_VALUE function feat(spanner/spannertest): support JSON_VALUE function Nov 29, 2021
@hengfengli hengfengli merged commit ac98735 into main Nov 29, 2021
5 checks passed
@hengfengli hengfengli deleted the spannertest-json-value branch Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner(spansql): DDL Parser errors on JSON_VALUE syntax
3 participants