test(bigtable): adds test proxy for Bigtable test suite #6568
Conversation
telpirion
added
the
do not merge
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: xl
product-auto-label
bot
added
size: l
bigtable/internal/testproxy/proxy.go
Outdated
| l := alf.ApplyLabelTransformer | ||
| al := bigtable.LabelFilter(l) | ||
| f = &al | ||
| default: |
There was a problem hiding this comment.
Since you're returning f below which would be nil if any of these case statements don't match, you can remove this branch OR just put a return in each case statement and remove the return f below. I personally find returning out of case statements easier to read when it gets this long.
There was a problem hiding this comment.
The compiler doesn't like the missing return statement, so I just deleted the default branch.
|
|
||
| return nil, nil | ||
| } | ||
| return creds, nil |
There was a problem hiding this comment.
You might consider returning out of the case statements above just because this switch statement is a little long. Up to you.
There was a problem hiding this comment.
The compiler doesn't like it if I remove the final return statement.
telpirion
added
the
automerge
bigtable/internal/testproxy/proxy.go
Outdated
|
|
||
| switch mut := mpb.Mutation; mut.(type) { | ||
| case *btpb.Mutation_DeleteFromColumn_: | ||
| del := mut.(*btpb.Mutation_DeleteFromColumn_) |
There was a problem hiding this comment.
Change the switch statement above to switch mut := mpb.Mutation.(type) { and you'll be able to remove these type assertions.
bigtable/internal/testproxy/proxy.go
Outdated
| // Filter object. | ||
| func filterFromProto(rfPb *btpb.RowFilter) *bigtable.Filter { | ||
| var f *bigtable.Filter | ||
| switch fpb := rfPb.Filter; fpb.(type) { |
There was a problem hiding this comment.
switch fpb := rfPb.Filter.(type) {|
|
||
| t.Log("testproxy test: client created successfully in test proxy") | ||
|
|
||
| _, err = (*client).RemoveClient(ctx, &pb.RemoveClientRequest{ |
| InstanceId: "instance", | ||
| } | ||
|
|
||
| _, err := (*client).CreateClient(ctx, req) |
gcf-merge-on-green
bot
removed
the
automerge
This PR is a follow-up to #6568 .
For use with the Bigtable test suite.