fix(pubsublite): close api clients when publisher clients have terminated #6867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated Refactors the closing of api clients, such that it is done automatically if the PublisherClient permanently fails due to error.
product-auto-label
bot
added
size: m
hongalex
approved these changes
Oct 17, 2022
tmdiep
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
🤖 I have created a release *beep* *boop* --- ## [1.4.1](https://togithub.com/googleapis/google-cloud-go/compare/pubsublite/v1.4.0...pubsublite/v1.4.1) (2022-10-18) ### Bug Fixes * **pubsublite:** Close api clients when publisher clients have terminated ([#6867](https://togithub.com/googleapis/google-cloud-go/issues/6867)) ([5cb5662](https://togithub.com/googleapis/google-cloud-go/commit/5cb5662ff28153e6764e54ef7245f000f0379e5a)) ### Documentation * **pubsublite:** Update publisher and subscriber client usage ([#6864](https://togithub.com/googleapis/google-cloud-go/issues/6864)) ([f9eb454](https://togithub.com/googleapis/google-cloud-go/commit/f9eb45439b0fa6e9cffdbd06eac0c540e3ed8db6)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the closing of API clients, such that it is done automatically if the PublisherClient permanently fails due to error.
compositeServiceis now passed acloseable, which is closed when theserviceTerminatedstate is reached. Users don't necessarily need to callPublisherClient.Stopif it has permanently failed in order to close the API clients, though it is good practice to always callStopwhen a publisher is not longer used.