test(storage): split out some of the object tests #7000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
tritone
reviewed
Nov 9, 2022
| if err = bkt.Object(publicObj).ACL().Set(ctx, AllUsers, RoleReader); err != nil { | ||
| t.Errorf("PutACLEntry failed with %v", err) | ||
| } | ||
| publicClient, err := newTestClient(ctx, option.WithoutAuthentication()) |
There was a problem hiding this comment.
Note that publicClient is always going to be HTTP in a comment.
There was a problem hiding this comment.
We discussed this offline - this needs to be split out (this code wasn't changed but appears like that since I split out parts of this test that were before and after this chunk). Right now this test is only run in HTTP.
I will split this part (Test public ACL) into 2 tests so that we can test public objects with gRPC and HTTP clients, but I'll save that for another PR.
tritone
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires yet more splitting - here's a start