Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datastore): Return Get, GetMulti, Put and PutMulti errors with enhanced details #7061

Merged
merged 9 commits into from
Dec 2, 2022
Merged

feat(datastore): Return Get, GetMulti, Put and PutMulti errors with enhanced details #7061

merged 9 commits into from
Dec 2, 2022

Commits on Nov 17, 2022

  1. feat: Fold multiArgCheck logic in get and also return descriptive errors 

    Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
    @ionicc
    ionicc committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    2284927 View commit details
    Browse the repository at this point in the history

  2. feat: Fold checkMultiArg logic in putMutations and add test for MultiPut 

    Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
    @ionicc
    ionicc committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    350d54f View commit details
    Browse the repository at this point in the history

  3. feat: Give key length and dst length during ErrDifferentKeyAndDstLength 

    Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
    @ionicc
    ionicc committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    7a108a6 View commit details
    Browse the repository at this point in the history

  4. feat: Unify errors declaration by only using fmt.Errorf 

    Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
    @ionicc
    ionicc committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    534521a View commit details
    Browse the repository at this point in the history

  5. feat: Add dst and key len error in PutMulti as well 

    Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
    @ionicc
    ionicc committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    afd9fc8 View commit details
    Browse the repository at this point in the history

  6. feat: Add comments in get as well 

    Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
    @ionicc
    ionicc committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    575fa33 View commit details
    Browse the repository at this point in the history

  7. feat: Add back previously used error.New 

    Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
    @ionicc
    ionicc committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    73181ec View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Merge branch 'main' into main

    Eric Schmidt committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    065b4b7 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Merge branch 'main' into main

    Eric Schmidt committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    838875d View commit details
    Browse the repository at this point in the history