Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firestore): EntityFilter for AND/OR queries #7757

Merged
merged 8 commits into from
Apr 21, 2023
Merged

feat(firestore): EntityFilter for AND/OR queries #7757

merged 8 commits into from
Apr 21, 2023

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Apr 14, 2023

Adding new method 'WhereEntity' to Query which can be used to construct composite queries.
Adding the following new structs to be used with FilterEntity

  • AndFilter
  • OrFilter
  • PropertyFilter
  • PropertyPathFilter

@bhshkh bhshkh requested review from a team as code owners April 14, 2023 05:23
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the Firestore API. labels Apr 14, 2023
@bhshkh bhshkh marked this pull request as draft April 14, 2023 08:50
@bhshkh bhshkh marked this pull request as ready for review April 14, 2023 08:54
@enocom enocom self-requested a review April 17, 2023 16:02
enocom
enocom approved these changes Apr 19, 2023
View reviewed changes
firestore/integration_test.go Show resolved Hide resolved
firestore/integration_test.go Show resolved Hide resolved
firestore/integration_test.go Outdated Show resolved Hide resolved
firestore/query.go Outdated Show resolved Hide resolved
firestore/query.go Outdated Show resolved Hide resolved
@bhshkh bhshkh enabled auto-merge (squash) April 21, 2023 03:49
codyoss
codyoss approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping for approval, deferring to @enocom review.

@bhshkh bhshkh merged commit ae37793 into googleapis:main Apr 21, 2023
@release-please release-please bot mentioned this pull request Apr 21, 2023
Merged
@bhshkh bhshkh deleted the or-firestore branch May 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhshkh @enocom @codyoss