-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): add support for cloud storage subscriptions #7977
Merged
hongalex
merged 16 commits into
googleapis:main
from
hongalex:feat-pubsub-storage-subscriptions
Jun 23, 2023
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e65bbb8
feat(pubsub): add support for cloud storage subscriptions
hongalex b52316c
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex c7b8063
Merge branch 'main' of github.com:googleapis/google-cloud-go into fea…
hongalex b7708bc
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex f4700e1
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex cbe3726
fix exported type style
hongalex 071fc70
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex a6b3e8e
fix bad sentinel value in gcs and bq subs
hongalex e8a0eb3
make cloud subscription fake behavior consistent with live service
hongalex 9c60ad2
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex 24f78dd
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex 15164e9
Merge branch 'main' of github.com:googleapis/google-cloud-go into fea…
hongalex 5d0a7c8
address review comments
hongalex 725858e
revert change that erroneously deletes bq config check
hongalex 82e8bfd
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex 40655f1
fix wording in one of comment
hongalex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some invariant here that ensures req.GetSubscription() doesn't return nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it's checked in the first lines above