Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): drop stream reference after closing it for gRPC writes #8872

Merged
merged 2 commits into from
Oct 27, 2023
Merged

fix(storage): drop stream reference after closing it for gRPC writes #8872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f288cb
fix(storage): drop stream reference after closing it for gRPC writes
BrennaEpp Oct 25, 2023
6ac0a0f
Merge branch 'main' into grpc-fix-write
BrennaEpp Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions storage/grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1660,6 +1660,10 @@ func (w *gRPCWriter) uploadBuffer(recvd int, start int64, doneReading bool) (*st
// status. Closing the stream receives the status as an error.
_, err = w.stream.CloseAndRecv()

// Drop the stream reference as a new one will need to be created if
// we can retry the upload
w.stream = nil

// Retriable errors mean we should start over and attempt to
// resend the entire buffer via a new stream.
// If not retriable, falling through will return the error received
Expand Down
Loading