test(storage): add object to encryption test to reduce rate limit issues #8938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
frankyn
reviewed
Oct 30, 2023
| // Copying an object without the key should fail. | ||
| if _, err := obj2.CopierFrom(obj).Run(ctx); err == nil { | ||
| if _, err := obj4.CopierFrom(obj).Run(ctx); err == nil { |
There was a problem hiding this comment.
looks like you can update lines 2526 - 2530 to use obj4 as well.
There was a problem hiding this comment.
That is true, but the objective here is to not use the same object consecutively if we can avoid it as the rate limit for objects is one create/update/delete per second. So IIUC L2562 will not hit that limit even if it occurs in the same second as 2522 - if we use the same object, it might.
frankyn
approved these changes
Oct 31, 2023
tritone
approved these changes
Oct 31, 2023
bhshkh
pushed a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8727
Test may fail again as we are writing several times to obj2 in a short amount of time. May need to add another object/more carefully interleave this one (to make sure we are still testing the same things). For now, adding this may be sufficient.