docs(storage): indicate that gRPC is incompatible with universe domains #9386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
quartzmo
requested changes
Feb 8, 2024
storage/storage.go
Outdated
| @@ -219,6 +219,7 @@ func NewClient(ctx context.Context, opts ...option.ClientOption) (*Client, error | |||
| // NewGRPCClient creates a new Storage client using the gRPC transport and API. | |||
| // Client methods which have not been implemented in gRPC will return an error. | |||
| // In particular, methods for Cloud Pub/Sub notifications are not supported. | |||
| // Using a non-default universe domain is also not supported in gRPC. | |||
There was a problem hiding this comment.
I'm just a tiny bit worried about this sentence being taken out of context. Can you change it to:
"Using a non-default universe domain is also not supported in the Storage gRPC client."
There was a problem hiding this comment.
That's fair. Updated!
quartzmo
approved these changes
Feb 8, 2024
tritone
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.