Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(main): release storage 1.39.0 #9457

Merged
merged 1 commit into from Feb 29, 2024
Merged

chore(main): release storage 1.39.0 #9457

merged 1 commit into from Feb 29, 2024

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Feb 23, 2024 •
edited

馃 I have created a release beep boop

1.39.0 (2024-02-29)

Features

  • storage: Make it possible to disable Content-Type sniffing (#9431) (0676670)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team as a code owner February 23, 2024 00:38
@release-please release-please bot requested a review from a team as a code owner February 23, 2024 00:38
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 23, 2024
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2024
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
e7a8cdf 
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to leave
`Content-Type` blank to use the `Response-Content-Type` override in a
signed URL. This commit adds the `DisableContentTypeDetection` option
to the the driver and passes along the value to make it possible to
keep Content-Type blank in the GCS object metadata.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
643f86b 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
@stanhu stanhu mentioned this pull request Feb 23, 2024
Merged
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
8066870 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
53a0705 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
74b5319 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
@release-please release-please bot force-pushed the release-please--branches--main--components--storage branch from f6bca80 to 45e45e2 Compare February 26, 2024 15:13
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2024
@stanhu
Copy link
Contributor

stanhu commented Feb 27, 2024

@tritone @frankyn Thanks for the review of #9431! Would one of you be able to push this release out?

@release-please release-please bot force-pushed the release-please--branches--main--components--storage branch from 45e45e2 to da9a490 Compare February 27, 2024 16:30
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@release-please release-please bot force-pushed the release-please--branches--main--components--storage branch from da9a490 to 123af7e Compare February 28, 2024 19:42
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@release-please release-please bot force-pushed the release-please--branches--main--components--storage branch from 123af7e to db60b44 Compare February 29, 2024 19:34
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@tritone tritone merged commit 58f5c44 into main Feb 29, 2024
13 checks passed
@tritone tritone deleted the release-please--branches--main--components--storage branch February 29, 2024 22:06
@tritone
Copy link
Contributor

tritone commented Feb 29, 2024

@stanhu should be out in a minute; apologies for the delay!

@release-please Release Please
Copy link
Contributor Author

馃 Release is at https://github.com/googleapis/google-cloud-go/releases/tag/storage/v1.39.0 馃尰

@release-trigger Release Trigger
Copy link

Triggered job: cloud-devrel/client-libraries/go/google-cloud-go/release (2024-02-29T22:08:45.259Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

@stanhu
Copy link
Contributor

stanhu commented Feb 29, 2024

@tritone Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
autorelease: tagged autorelease: triggered owlbot:run Add this label to trigger the Owlbot post processor. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stanhu @tritone @kokoro-team