feat(spanner): add support for change streams transaction exclusion option #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuranZhang
force-pushed
the
spanner-cdc-txn-exclusion
branch
from
79a3207
to
abbc23a
Compare
dedocibula
reviewed
Apr 16, 2024
dedocibula
reviewed
Apr 16, 2024
ShuranZhang
force-pushed
the
spanner-cdc-txn-exclusion
branch
from
abbc23a
to
26ba6b0
Compare
rahul2393
reviewed
Apr 19, 2024
rahul2393
approved these changes
Apr 19, 2024
ShuranZhang
force-pushed
the
spanner-cdc-txn-exclusion
branch
from
26ba6b0
to
f0f2dc4
Compare
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
changed the title
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for excluding transactions from being recorded in the change streams by passing a new boolean option
ExcludeTxnFromChangeStreamsin the various write APIs:This pr follows the exact same design with the merged Java client lib pr for this feature at googleapis/java-spanner#2959 including error handling.
Passing this option to a request level DML request will receive an error
errExcludeRequestLevelDmlFromChangeStreams. This new option is added tostruct QueryOptions, but it can only be used forPartitionedUpdateAPI.Note: Samples will be added later in separate prs.