fix: [run] Removes accidentally exposed field service.traffic_tags_cl…

…eanup_threshold in Cloud Run Service (#9908) * fix: Removes accidentally exposed field service.traffic_tags_cleanup_threshold in Cloud Run Service docs: Minor comment fixes PiperOrigin-RevId: 568981386 Source-Link: googleapis/googleapis@01711ae Source-Link: googleapis/googleapis-gen@cc2e659 Copy-Tag: eyJwIjoiamF2YS1ydW4vLk93bEJvdC55YW1sIiwiaCI6ImNjMmU2NTlmOGNmNWE0NThkNmY3YTJjMGY4ZjdjZmE1NGVmNTQwMmMifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Sep 28, 2023 · ad81708 · ad81708
1 parent 3c7c1dc
commit ad81708
Show file tree

Hide file tree

Showing 12 changed files with 92 additions and 238 deletions.
diff --git a/java-run/README.md b/java-run/README.md
@@ -45,20 +45,20 @@ If you are using Maven without the BOM, add this to your dependencies:
 <dependency>
   <groupId>com.google.cloud</groupId>
   <artifactId>google-cloud-run</artifactId>
-  <version>0.25.0</version>
+  <version>0.24.0</version>
 </dependency>
 ```
 
 If you are using Gradle without BOM, add this to your dependencies:
 
 ```Groovy
-implementation 'com.google.cloud:google-cloud-run:0.25.0'
+implementation 'com.google.cloud:google-cloud-run:0.24.0'
 ```
 
 If you are using SBT, add this to your dependencies:
 
 ```Scala
-libraryDependencies += "com.google.cloud" % "google-cloud-run" % "0.25.0"
+libraryDependencies += "com.google.cloud" % "google-cloud-run" % "0.24.0"
 ```
 <!-- {x-version-update-end} -->
 

diff --git a/...un/google-cloud-run/src/test/java/com/google/cloud/run/v2/ServicesClientHttpJsonTest.java b/...un/google-cloud-run/src/test/java/com/google/cloud/run/v2/ServicesClientHttpJsonTest.java
@@ -125,7 +125,6 @@ public void createServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -210,7 +209,6 @@ public void createServiceTest2() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -295,7 +293,6 @@ public void getServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -371,7 +368,6 @@ public void getServiceTest2() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -547,7 +543,6 @@ public void updateServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -591,7 +586,6 @@ public void updateServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -654,7 +648,6 @@ public void updateServiceExceptionTest() throws Exception {
               .setUri("uri116076")
               .addAllCustomAudiences(new ArrayList<String>())
               .setSatisfiesPzs(true)
-              .setTrafficTagsCleanupThreshold(-795495828)
               .setReconciling(true)
               .setEtag("etag3123477")
               .build();
@@ -698,7 +691,6 @@ public void deleteServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -779,7 +771,6 @@ public void deleteServiceTest2() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();

diff --git a/java-run/google-cloud-run/src/test/java/com/google/cloud/run/v2/ServicesClientTest.java b/java-run/google-cloud-run/src/test/java/com/google/cloud/run/v2/ServicesClientTest.java
@@ -133,7 +133,6 @@ public void createServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -217,7 +216,6 @@ public void createServiceTest2() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -301,7 +299,6 @@ public void getServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -371,7 +368,6 @@ public void getServiceTest2() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -529,7 +525,6 @@ public void updateServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -607,7 +602,6 @@ public void deleteServiceTest() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();
@@ -685,7 +679,6 @@ public void deleteServiceTest2() throws Exception {
             .setUri("uri116076")
             .addAllCustomAudiences(new ArrayList<String>())
             .setSatisfiesPzs(true)
-            .setTrafficTagsCleanupThreshold(-795495828)
             .setReconciling(true)
             .setEtag("etag3123477")
             .build();

diff --git a/java-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/EnvVar.java b/java-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/EnvVar.java
@@ -118,8 +118,8 @@ public ValuesCase getValuesCase() {
    *
    *
    * <pre>
-   * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-   * must not exceed 32768 characters.
+   * Required. Name of the environment variable. Must not exceed 32768
+   * characters.
    * </pre>
    *
    * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -142,8 +142,8 @@ public java.lang.String getName() {
    *
    *
    * <pre>
-   * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-   * must not exceed 32768 characters.
+   * Required. Name of the environment variable. Must not exceed 32768
+   * characters.
    * </pre>
    *
    * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -743,8 +743,8 @@ public Builder clearValues() {
      *
      *
      * <pre>
-     * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-     * must not exceed 32768 characters.
+     * Required. Name of the environment variable. Must not exceed 32768
+     * characters.
      * </pre>
      *
      * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -766,8 +766,8 @@ public java.lang.String getName() {
      *
      *
      * <pre>
-     * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-     * must not exceed 32768 characters.
+     * Required. Name of the environment variable. Must not exceed 32768
+     * characters.
      * </pre>
      *
      * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -789,8 +789,8 @@ public com.google.protobuf.ByteString getNameBytes() {
      *
      *
      * <pre>
-     * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-     * must not exceed 32768 characters.
+     * Required. Name of the environment variable. Must not exceed 32768
+     * characters.
      * </pre>
      *
      * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -811,8 +811,8 @@ public Builder setName(java.lang.String value) {
      *
      *
      * <pre>
-     * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-     * must not exceed 32768 characters.
+     * Required. Name of the environment variable. Must not exceed 32768
+     * characters.
      * </pre>
      *
      * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -829,8 +829,8 @@ public Builder clearName() {
      *
      *
      * <pre>
-     * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-     * must not exceed 32768 characters.
+     * Required. Name of the environment variable. Must not exceed 32768
+     * characters.
      * </pre>
      *
      * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>

diff --git a/...-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/EnvVarOrBuilder.java b/...-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/EnvVarOrBuilder.java
@@ -27,8 +27,8 @@ public interface EnvVarOrBuilder
    *
    *
    * <pre>
-   * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-   * must not exceed 32768 characters.
+   * Required. Name of the environment variable. Must not exceed 32768
+   * characters.
    * </pre>
    *
    * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -40,8 +40,8 @@ public interface EnvVarOrBuilder
    *
    *
    * <pre>
-   * Required. Name of the environment variable. Must be a C_IDENTIFIER, and
-   * must not exceed 32768 characters.
+   * Required. Name of the environment variable. Must not exceed 32768
+   * characters.
    * </pre>
    *
    * <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>

diff --git a/java-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/RunJobRequest.java b/java-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/RunJobRequest.java
@@ -193,7 +193,7 @@ com.google.cloud.run.v2.RunJobRequest.Overrides.ContainerOverride getContainerOv
    *
    *
    * <pre>
-   * RunJob Overrides that contains Execution fields to be overridden on the go.
+   * RunJob Overrides that contains Execution fields to be overridden.
    * </pre>
    *
    * Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides}
@@ -391,7 +391,7 @@ public interface ContainerOverrideOrBuilder
      *
      *
      * <pre>
-     * Per container override specification.
+     * Per-container override specification.
      * </pre>
      *
      * Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides.ContainerOverride}
@@ -849,7 +849,7 @@ protected Builder newBuilderForType(
        *
        *
        * <pre>
-       * Per container override specification.
+       * Per-container override specification.
        * </pre>
        *
        * Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides.ContainerOverride}
@@ -2254,7 +2254,7 @@ protected Builder newBuilderForType(
      *
      *
      * <pre>
-     * RunJob Overrides that contains Execution fields to be overridden on the go.
+     * RunJob Overrides that contains Execution fields to be overridden.
      * </pre>
      *
      * Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides}