Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate AsyncLoggingHandler? #1532

Closed
gregw opened this issue Jan 13, 2017 · 5 comments
Closed

Deprecate AsyncLoggingHandler? #1532

gregw opened this issue Jan 13, 2017 · 5 comments
Assignees
@michaelbausor
Labels
api: logging Issues related to the Cloud Logging API.

Comments

@gregw
Copy link

gregw commented Jan 13, 2017

The fix for #1386 has made the normal LoggingHandler asynchronous! Was this deliberate? If so, should the AsyncLoggingHandler be deprecated as it now no longer changes behaviour.
@garrettjonesgoogle
Copy link
Member

Hmm I think I should actually switch the main one back to synchronous. I overlooked the separate asynchronous class which people can use. What I do think should be done though is to switch the example to suggest the asynchronous one because it will be more performant.

@garrettjonesgoogle garrettjonesgoogle added the api: logging Issues related to the Cloud Logging API. label Jan 13, 2017
@gregw gregw mentioned this issue Jan 13, 2017
Merged
@garrettjonesgoogle
Copy link
Member

I think this needs to be cleaned up before GA.

@garrettjonesgoogle
Copy link
Member

We should delete this altogether, and support a setting for sync v async in the logging config.

@michaelbausor michaelbausor mentioned this issue Mar 8, 2017
Merged
@michaelbausor
Copy link
Contributor

Closed in #1716

@gregw
Copy link
Author

gregw commented Mar 9, 2017

Could the AsyncLoggingHandler be left as a deprecated extension of LoggingHandler, as that will make transitioning usage easier?

github-actions bot pushed a commit to renovate-bot/google-cloud-java that referenced this issue Oct 8, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
97ba569 
…1.3 (googleapis#1532)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigquerydatatransfer).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIxOS4xIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbausor michaelbausor

Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gregw @danoscarmike @garrettjonesgoogle @michaelbausor