Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [discoveryengine] new module for discoveryengine #8646

Merged
merged 6 commits into from
Oct 21, 2022
Merged

feat: [discoveryengine] new module for discoveryengine #8646

merged 6 commits into from
Oct 21, 2022

Conversation

meltsufin
Copy link
Member

  • feat: initial generation of discoveryengine
  • build: add the discoveryengine module to monorepo

@ddixit14
Copy link
Contributor

ddixit14 commented Oct 21, 2022 •
edited
Loading

@meltsufin, did you enhance new-client.py to fix consolidate-config and parent-pom somehow? Because I generated contentwarehouse and had to fix these manually.
The commit chore: re-run modified new-client.py caught my attention..

@meltsufin
Copy link
Member Author

@ddixit14 Yes I enhanced it. See: #8653.
cc/ @suztomo

@meltsufin meltsufin marked this pull request as ready for review October 21, 2022 18:07
@meltsufin meltsufin mentioned this pull request Oct 21, 2022
Merged
@meltsufin meltsufin merged commit 7b2a1bd into main Oct 21, 2022
@meltsufin meltsufin deleted the new_module_java-discoveryengine branch October 21, 2022 19:55
@release-please release-please bot mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddixit14 ddixit14 ddixit14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltsufin @ddixit14