Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub Emulator: subscriptions to deleted topics preserve old topic #988

Closed
mziccard opened this issue May 6, 2016 · 4 comments
Closed
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. triaged for GA

Comments

@mziccard
Copy link
Contributor

mziccard commented May 6, 2016

As documented in projects.topics/delete when a topic is deleted existing subscriptions to this topic are not deleted, but their topic field is set to _deleted-topic_.

When testing agains the Pub/Sub emulator subscriptions to a deleted topic have their topic field still set to the deleted topic's name.

@mziccard mziccard added api: pubsub Issues related to the Pub/Sub API. testing labels May 6, 2016
@mziccard
Copy link
Contributor Author

mziccard commented May 6, 2016

@garrettjonesgoogle
Copy link
Member

It looks like the topic field name is fixed - any appropriate changes in google-cloud-java can now be made.

@garrettjonesgoogle
Copy link
Member

@pongad can you triage?

@michaelbausor michaelbausor added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 8, 2017
@pongad
Copy link
Contributor

pongad commented Jul 13, 2017

Pubsub no longer uses emulator for testing. I think we're safe to close this.

@pongad pongad closed this as completed Jul 13, 2017
github-actions bot pushed a commit that referenced this issue Jul 14, 2022
🤖 I have created a release *beep* *boop*
---


## [3.1.0](googleapis/java-aiplatform@v3.0.0...v3.1.0) (2022-07-13)


### Features

* **samples:** add remaining featurestore api samples ([#974](googleapis/java-aiplatform#974)) ([99ea51d](googleapis/java-aiplatform@99ea51d))
* **samples:** added all entity type samples ([#976](googleapis/java-aiplatform#976)) ([f496d8a](googleapis/java-aiplatform@f496d8a))


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-aiplatform/issues/1485)) ([#991](googleapis/java-aiplatform#991)) ([c41d394](googleapis/java-aiplatform@c41d394))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Aug 25, 2022
…#988)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.9` -> `2.8.10` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/compatibility-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/confidence-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.10`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2810-httpsgithubcomgoogleapisjava-corecomparev289v2810-2022-08-24)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.9...v2.8.10)

##### Dependencies

-   update dependency com.google.api:gax-bom to v2.19.0 ([#&#8203;907](https://togithub.com/googleapis/java-core/issues/907)) ([51b824c](https://togithub.com/googleapis/java-core/commit/51b824c225fd7095138e1ec2b6d47af4e2a34352))
-   update dependency io.grpc:grpc-bom to v1.49.0 ([#&#8203;908](https://togithub.com/googleapis/java-core/issues/908)) ([fbccd2d](https://togithub.com/googleapis/java-core/commit/fbccd2daceb0984c7cb95f84f89a116e54bf4ddc))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzQuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE3NC4xIn0=-->
github-actions bot pushed a commit that referenced this issue Sep 19, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Nov 9, 2022
…1.4 (#988)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC45LjIifQ==-->
suztomo pushed a commit that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. triaged for GA
Projects
None yet
Development

No branches or pull requests

4 participants