Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: generate libraries at Wed Mar 13 03:07:38 UTC 2024 #10529

Merged
merged 4 commits into from
Mar 13, 2024
Merged

chore: generate libraries at Wed Mar 13 03:07:38 UTC 2024 #10529

merged 4 commits into from
Mar 13, 2024

Conversation

cloud-java-bot
Copy link
Collaborator

@cloud-java-bot cloud-java-bot commented Mar 12, 2024 •
edited by diegomarquezp
Loading

This pull request is generated with proto changes between googleapis commit 97e3b44f2f08bd0ffff128872519e619750c7892 (exclusive) and e960a82d36e3ddaeb62f549dbd4c300e11e240dc (inclusive).
Qualified commits are:
googleapis/googleapis@e960a82
googleapis/googleapis@1793994
googleapis/googleapis@14d09ef
googleapis/googleapis@eebdbe4
googleapis/googleapis@716a939
googleapis/googleapis@b553626
googleapis/googleapis@d66613f
googleapis/googleapis@e0791ad
googleapis/googleapis@87e7c58
googleapis/googleapis@4664532
googleapis/googleapis@a09d145
googleapis/googleapis@3ad1aad
googleapis/googleapis@fe77120
googleapis/googleapis@6af2938
googleapis/googleapis@f0a78c7
googleapis/googleapis@8d73440
googleapis/googleapis@792dacb
googleapis/googleapis@324b281
googleapis/googleapis@2edc359
googleapis/googleapis@cd32d53
googleapis/googleapis@49ea2c0
googleapis/googleapis@7659dd2
googleapis/googleapis@05d889e
googleapis/googleapis@d007ca1
googleapis/googleapis@3ca2e0b
BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
docs: [cloudquotas] A comment for field filter in message .google.api.cloudquotas.v1.ListQuotaPreferencesRequest is changed
docs: [cloudquotas] A comment for field order_by in message .google.api.cloudquotas.v1.ListQuotaPreferencesRequest is changed

PiperOrigin-RevId: 615202751

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [security-private-ca] Add custom subject key identifier field
feat: [security-private-ca] Add support for fine-grained maximum certificate lifetime controls
docs: [security-private-ca] A comment for field subject in message .google.cloud.security.privateca.v1.CertificateConfig is changed
docs: [security-private-ca] A comment for method FetchCaCerts in service CertificateAuthorityService is changed
docs: [security-private-ca] A comment for field ca_certs in message .google.cloud.security.privateca.v1.FetchCaCertsResponse is changed

PiperOrigin-RevId: 615112752

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [dialogflow] added text sections to the submitted summary
feat: [dialogflow] added conformer model migration opt out flag
docs: [dialogflow] clarified wording around END_OF_SINGLE_UTTERANCE

PiperOrigin-RevId: 614805668

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [aiplatform] A new value NVIDIA_H100_80GB is added to enum AcceleratorType
feat: [aiplatform] A new enum HarmSeverity is added
feat: [aiplatform] A new field probability_score is added to message .google.cloud.aiplatform.v1.SafetyRating
feat: [aiplatform] A new field severity is added to message .google.cloud.aiplatform.v1.SafetyRating
feat: [aiplatform] A new field severity_score is added to message .google.cloud.aiplatform.v1.SafetyRating
feat: [aiplatform] A new value BLOCKLIST is added to enum FinishReason
feat: [aiplatform] A new value PROHIBITED_CONTENT is added to enum FinishReason
feat: [aiplatform] A new value SPII is added to enum FinishReason
feat: [aiplatform] A new field grounding_metadata is added to message .google.cloud.aiplatform.v1.Candidate
feat: [aiplatform] A new message Segment is added
feat: [aiplatform] A new message GroundingAttribution is added
feat: [aiplatform] A new message GroundingMetadata is added
feat: [aiplatform] A new field display_name is added to message .google.cloud.aiplatform.v1.DatasetVersion
feat: [aiplatform] A new field metadata is added to message .google.cloud.aiplatform.v1.DatasetVersion
feat: [aiplatform] A new field project_number is added to message .google.cloud.aiplatform.v1.FeatureView
feat: [aiplatform] A new message SyncSummary is added
feat: [aiplatform] A new field sync_summary is added to message .google.cloud.aiplatform.v1.FeatureViewSync
feat: [aiplatform] A new value NOT_EQUAL is added to enum Operator
feat: [aiplatform] A new message BaseModelSource is added
feat: [aiplatform] A new field base_model_source is added to message .google.cloud.aiplatform.v1.Model
feat: [aiplatform] A new message ModelGardenSource is added
feat: [aiplatform] A new message GenieSource is added
feat: [aiplatform] A new method BatchDeletePipelineJobs is added to service PipelineService
feat: [aiplatform] A new method BatchCancelPipelineJobs is added to service PipelineService
feat: [aiplatform] A new message BatchCancelPipelineJobsOperationMetadata is added
feat: [aiplatform] A new message BatchDeletePipelineJobsRequest is added
feat: [aiplatform] A new message BatchDeletePipelineJobsResponse is added
feat: [aiplatform] A new message BatchCancelPipelineJobsRequest is added
feat: [aiplatform] A new message BatchCancelPipelineJobsResponse is added
feat: [aiplatform] A new field retrieval is added to message .google.cloud.aiplatform.v1.Tool
feat: [aiplatform] A new field google_search_retrieval is added to message .google.cloud.aiplatform.v1.Tool
feat: [aiplatform] A new message Retrieval is added
feat: [aiplatform] A new message VertexAISearch is added
feat: [aiplatform] A new message GoogleSearchRetrieval is added
docs: [aiplatform] various documentation improvements

PiperOrigin-RevId: 614723899

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix!: [discoveryengine] http_uri fix for method ListChunks in service ChunkService

PiperOrigin-RevId: 614683212

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [discoveryengine] support acl-based and blended search
feat: [discoveryengine] support chunk-based document search
feat: [discoveryengine] support search adaptor based search
feat: [discoveryengine] support batch documents purge with GCS input
feat: [discoveryengine] add document processing config services
feat: [discoveryengine] add serving config services
feat: [discoveryengine] add billing estimation services
feat: [discoveryengine] add suggestion deny list import/purge services
docs: [discoveryengine] keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 614160461

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [discoveryengine] support blended search
feat: [discoveryengine] support boost in multi-turn search
feat: [discoveryengine] add document processing config services
feat: [discoveryengine] add search tuning services
feat: [discoveryengine] allow setting schema on schema creation
docs: [discoveryengine] keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 614046598

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [securitycenter] Add security_posture, external_system.case_uri, external_system.case_priority, external_system.case_sla, external_system.case_create_time, external_system.case_close_time, and external_system.ticket_info to finding's list of attributes

PiperOrigin-RevId: 614027711

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [network-management] add new NAT fields to Network Management API definition

PiperOrigin-RevId: 613999902

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [network-management] add new load balancer fields to public API

PiperOrigin-RevId: 613975155

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix!: [workspaceevents] ListSubscription overloaded method parameters changed from page_size,page_token,filter to just filter in some languages
docs: [workspaceevents] A comment for message Subscription is changed
docs: [workspaceevents] A comment for field target_resource in message .google.apps.events.subscriptions.v1.Subscription is changed
docs: [workspaceevents] A comment for field event_types in message .google.apps.events.subscriptions.v1.Subscription is changed

PiperOrigin-RevId: 613683510

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [securitycenter] Added security center api V2 client library

PiperOrigin-RevId: 613632579

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: [netapp] mark optional fields explicitly in Storage Pool
docs: [netapp] change comments of the psa_range field to note it is currently not implemented
docs: [netapp] update comments of ServiceLevel and EncryptionType

PiperOrigin-RevId: 613376353

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix!: [aiplatform] An existing field preflight_validations is removed from message .google.cloud.aiplatform.v1beta1.CreatePipelineJobRequest
feat: [aiplatform] A new enum HarmSeverity is added
feat: [aiplatform] A new field probability_score is added to message .google.cloud.aiplatform.v1beta1.SafetyRating
feat: [aiplatform] A new field severity is added to message .google.cloud.aiplatform.v1beta1.SafetyRating
feat: [aiplatform] A new field severity_score is added to message .google.cloud.aiplatform.v1beta1.SafetyRating
feat: [aiplatform] A new value BLOCKLIST is added to enum FinishReason
feat: [aiplatform] A new value PROHIBITED_CONTENT is added to enum FinishReason
feat: [aiplatform] A new value SPII is added to enum FinishReason
feat: [aiplatform] A new field display_name is added to message .google.cloud.aiplatform.v1beta1.DatasetVersion
feat: [aiplatform] A new field metadata is added to message .google.cloud.aiplatform.v1beta1.DatasetVersion
feat: [aiplatform] A new field project_number is added to message .google.cloud.aiplatform.v1beta1.FeatureView
feat: [aiplatform] A new message SyncSummary is added
feat: [aiplatform] A new field sync_summary is added to message .google.cloud.aiplatform.v1beta1.FeatureViewSync
feat: [aiplatform] A new value NOT_EQUAL is added to enum Operator
feat: [aiplatform] A new message BaseModelSource is added
feat: [aiplatform] A new field base_model_source is added to message .google.cloud.aiplatform.v1beta1.Model
feat: [aiplatform] A new message ModelGardenSource is added
feat: [aiplatform] A new message GenieSource is added
feat: [aiplatform] A new field progress_message is added to message .google.cloud.aiplatform.v1beta1.CreatePersistentResourceOperationMetadata
feat: [aiplatform] A new field progress_message is added to message .google.cloud.aiplatform.v1beta1.UpdatePersistentResourceOperationMetadata
feat: [aiplatform] A new field preflight_validations is added to message .google.cloud.aiplatform.v1beta1.PipelineJob
docs: [aiplatform] various documentation improvements

PiperOrigin-RevId: 613262431

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [container] add API to enable/disable secret manager csi component on GKE clusters

PiperOrigin-RevId: 613195917

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [container] add API to enable/disable secret manager csi component on GKE clusters

PiperOrigin-RevId: 613087806

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [container] add secondary boot disks field to NodePool API

PiperOrigin-RevId: 613011062

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [asset] Add asset_type field to GovernedIamPolicy and GovernedResource
feat: [asset] Add effective_tags field to GovernedResource
feat: [asset] Add fields project, folders, organization and effective_tags to GovernedContainer
feat: [asset] Add fields project, folders and organization to OrgPolicyResult
feat: [asset] Add field condition_evaluation to AnalyzerOrgPolicy.Rule
docs: [asset] Update comment for rpc AnalyzeOrgPolicyGovernedAssets to include additional canned constraints

PiperOrigin-RevId: 612934037

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: [apphub] Updated wording on App Hub service

PiperOrigin-RevId: 612873076

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [dlp] add RPCs for getting and listing project, table, and column data profiles
docs: [dlp] Update urls to reflect branding change to Sensitive Data Protection

PiperOrigin-RevId: 612872273

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [recaptchaenterprise] Add include_recaptcha_script for as a new action in firewall policies

PiperOrigin-RevId: 612851792

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: [cloudcontrolspartner] update documentation URL

PiperOrigin-RevId: 612723053

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [cloudcontrolspartner] added CloudControlsPartner API

PiperOrigin-RevId: 612632640

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: [batch] changed retry settings for UpdateJob

PiperOrigin-RevId: 612613447

END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: [batch] changed retry settings for UpdateJob

PiperOrigin-RevId: 612613286

END_NESTED_COMMIT
END_COMMIT_OVERRIDE

@cloud-java-bot cloud-java-bot requested a review from a team as a code owner March 12, 2024 17:23
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Mar 12, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 115 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@diegomarquezp
Copy link
Contributor

chore(ruby): Configure client for google-apps-chat

Maybe this is a case where we should ignore the commit?
Otherwise the description looks OK

@blakeli0
Copy link
Contributor

chore(ruby): Configure client for google-apps-chat

Maybe this is a case where we should ignore the commit? Otherwise the description looks OK

I agree. @JoeWang1127 Looking at the relevant commit, it only touches BUILD.bazel file, I think we should exclude BUILD.bazel file changes when we generate the commit history.

@diegomarquezp
Copy link
Contributor

diegomarquezp commented Mar 12, 2024 •
edited
Loading

chore(ruby): Configure client for google-apps-chat

Maybe this is a case where we should ignore the commit? Otherwise the description looks OK

I agree. @JoeWang1127 Looking at the relevant commit, it only touches BUILD.bazel file, I think we should exclude BUILD.bazel file changes when we generate the commit history.

I see. How likely is that a commit touches the input protos and proto dependencies? If it's not frequent then ignoring the BUILD files is fine imo. If it's frequent we may want to have a more sophisticated check in the future.

@blakeli0 blakeli0 requested a review from chingor13 March 12, 2024 20:24
@chingor13
Copy link
Contributor

Maybe this is a case where we should ignore the commit? Otherwise the description looks OK

I don't have a solution for you for figuring out which commits are actually in scope, but this is one reason owlbot previously ran bazel at each commit -- to see if/which clients actually changed from a given commit.

chore(ruby): Configure client for google-apps-chat

This commit message won't appear in the release notes (it's a chore). However it's possible something that didn't actually affect you makes it in (like fix(ruby): adjust ruby namespace)

@chingor13
Copy link
Contributor

Also, note that the PR body is getting long -- IIRC GitHub has a PR body limit of 65536 characters.

@blakeli0
Copy link
Contributor

blakeli0 commented Mar 12, 2024 •
edited
Loading

How likely is that a commit touches the input protos and proto dependencies?

Not very often. If it happens and it is already part of dependencies, e.g. java-common-protos, then everything should continue to work. But if it happens and it is a brand new proto that does not exist in java-common-protos, I think the generated code would fail to compile based on our current scripts. Which gives us a signal that the new proto has to be added to java-common-protos first.

@JoeWang1127
Copy link
Contributor

Also, note that the PR body is getting long -- IIRC GitHub has a PR body limit of 65536 characters.

I think this is fine since there're less than 20000 characters.

@cloud-java-bot cloud-java-bot changed the title chore: generate libraries at Tue Mar 12 17:21:49 UTC 2024 chore: generate libraries at Wed Mar 13 03:07:38 UTC 2024 Mar 13, 2024
@JoeWang1127 JoeWang1127 reopened this Mar 13, 2024
@JoeWang1127 JoeWang1127 merged commit 392ff2d into main Mar 13, 2024
29 of 31 checks passed
@JoeWang1127 JoeWang1127 deleted the generate-libraries-main branch March 13, 2024 15:41
@JoeWang1127 JoeWang1127 added the release-please:force-run To run release-please label Mar 13, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 13, 2024
@diegomarquezp diegomarquezp added the release-please:force-run To run release-please label Mar 13, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 13, 2024
@diegomarquezp diegomarquezp added the release-please:force-run To run release-please label Mar 13, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 13, 2024
@diegomarquezp diegomarquezp added release-please:force-run To run release-please and removed release-please:force-run To run release-please labels Mar 13, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 13, 2024
@diegomarquezp
Copy link
Contributor

@JoeWang1127 we found this entry to be duplicated (along with others)

  • feat: [aiplatform] A new enum HarmSeverity is added

It happens for aiplatform/v1 and v1beta1. We may need a way to distinguish/squash them.

@JoeWang1127 JoeWang1127 mentioned this pull request Mar 13, 2024
Merged
JoeWang1127 added a commit to googleapis/sdk-platform-java that referenced this pull request Mar 13, 2024
@JoeWang1127
chore: modify pr description (#2568)
ff56a20 
In this PR:
- Wrap commit message with `BEGIN_COMMIT_OVERRIDE` and
`BEGIN_COMMIT_OVERRIDE`.

Context: we found out that the commit messages in
googleapis/google-cloud-java#10529 didn't appear
in the release notes. @chingor13 pointed out that we should wrap commit
messages with `BEGIN_COMMIT_OVERRIDE` and `BEGIN_COMMIT_OVERRIDE` so
that release-please can pick them up from a merged PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cloud-java-bot @diegomarquezp @blakeli0 @chingor13 @JoeWang1127 @suztomo