Refactor IAM-related classes to be ready to support more services #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove resourcemanager's Policy class - Rename core's IamPolicy to Policy - Add Role class to hold string values for roles - Add Policy.Marshaller and Policy.DefaultMarshaller classes to convert Policy to/from gRPC protos - Add PolicyMarshaller to resourcemanager to convert Policy to/from resourcemanager's protos - Update READMEs, javadoc and examples
mziccard
added
api: core
api: cloudresourcemanager
googlebot
added
the
cla: yes
| @@ -37,69 +44,127 @@ | |||
| * a set of identities to a role, where the identities can be user accounts, Google groups, Google | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good (only skimmed the tests though). Few comments/suggestions. I am not convinced that we should put the Policy under iam sub-package unless we expect to have more kinds of policies in the future but fine either way. |
|
LGTM |
mziccard
force-pushed
the
refactor-iam
branch
from
b3c94f6
to
462910e
Compare
|
Comments fixed, PTAL
I was considering to put: |
|
LGTM (one comment was not addressed, your call). |
|
@aozarov Another thing we might want to discuss is wether to store |
|
My preference would be that as long as we wrap (and not expose) the underlying protobuf we should return it as String (which is also what we did for the api-client based Services). |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
…#1224) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.9` -> `2.8.10` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzQuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE3NC4xIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [2.3.6](googleapis/java-automl@v2.3.5...v2.3.6) (2022-08-25) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1224](googleapis/java-automl#1224)) ([731ed9f](googleapis/java-automl@731ed9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Aug 25, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
PolicyclassIamPolicytoPolicyRoleclass to hold string values for rolesPolicy.MarshallerandPolicy.DefaultMarshallerclasses to convertPolicyto/from gRPC protosPolicyMarshallerto resourcemanager to convertPolicyto/from resourcemanager's protos@aozarov @ajkannan do you mind having a look? Also, should we add an
iampackage?