Provide a way to unset blob metadata #279

mziccard · 2015-10-22T12:43:42Z

This PR follows from #60 and provides a different solution from #276.
If blobInfo metadata are set to null then Data.nullOf(ImmutableEmptyMap.class) is used. This way patch is capable of unsetting the metadata if need be.

This PR also documents patch behavior in Blob and Storage javadocs, code snippets are added to show how to unset blob's metadata.

We could consider moving ImmutableEmptyMap out of BlobInfo, thoughts?

gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobInfo.java

@@ -81,6 +84,14 @@ public StorageObject apply(BlobInfo blobInfo) {
  private final String contentLanguage;
  private final Integer componentCount;

+  public static final class ImmutableEmptyMap<K, V> extends AbstractMap<K, V> {


aozarov · 2015-10-22T20:49:39Z

Good job, I like it and I think we should go with this option for fixing #60.

@mziccard What do you think?

mziccard · 2015-10-22T21:01:49Z

@aozarov I agree, this is much cleaner than #276 and provides a reasonable way of circumventing #60. I'll take care of addressing all your comments.

- Use HashMap instead of ImmutableMap in builder.metadata - Use Collections.unmodifiableMap in blobInfo.metadata getter - Convert null values in metadata to Data.nullOf in blobInfo.toPb - Add integration tests - Add javadoc to mark BlobInfo.ImmutableEmptyMap as internal

Provide a way to unset blob metadata

@miraleung

Committer: @miraleung PiperOrigin-RevId: 378266372 Source-Link: googleapis/googleapis@9e31055 Source-Link: googleapis/googleapis-gen@14629f6

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.0 (#279) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-project-info-reports-plugin)) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-api-gateway).

🤖 I have created a release *beep* *boop* --- ## [1.2.3](googleapis/java-networkconnectivity@v1.2.2...v1.2.3) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#278](googleapis/java-networkconnectivity#278)) ([c9d00a8](googleapis/java-networkconnectivity@c9d00a8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jeepney](https://gitlab.com/takluyver/jeepney) | `==0.7.1` -> `==0.8.0` | [![age](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/compatibility-slim/0.7.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/confidence-slim/0.7.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dms).

🤖 I have created a release *beep* *boop* --- ## [2.2.6](googleapis/java-dms@v2.2.5...v2.2.6) (2022-09-29) ### Dependencies * Update dependency cachetools to v5 ([#288](googleapis/java-dms#288)) ([9370173](googleapis/java-dms@9370173)) * Update dependency certifi to v2022.9.24 ([#268](googleapis/java-dms#268)) ([1745004](googleapis/java-dms@1745004)) * Update dependency charset-normalizer to v2.1.1 ([#272](googleapis/java-dms#272)) ([367ffd9](googleapis/java-dms@367ffd9)) * Update dependency click to v8.1.3 ([#273](googleapis/java-dms#273)) ([328f00b](googleapis/java-dms@328f00b)) * Update dependency gcp-releasetool to v1.8.8 ([#269](googleapis/java-dms#269)) ([7d68646](googleapis/java-dms@7d68646)) * Update dependency google-api-core to v2.10.1 ([#274](googleapis/java-dms#274)) ([03bc3c5](googleapis/java-dms@03bc3c5)) * Update dependency google-auth to v2.12.0 ([#275](googleapis/java-dms#275)) ([bd96264](googleapis/java-dms@bd96264)) * Update dependency google-cloud-core to v2.3.2 ([#270](googleapis/java-dms#270)) ([fcd6bbd](googleapis/java-dms@fcd6bbd)) * Update dependency google-cloud-storage to v2.5.0 ([#276](googleapis/java-dms#276)) ([80b39f1](googleapis/java-dms@80b39f1)) * Update dependency google-crc32c to v1.5.0 ([#277](googleapis/java-dms#277)) ([a561425](googleapis/java-dms@a561425)) * Update dependency googleapis-common-protos to v1.56.4 ([#271](googleapis/java-dms#271)) ([296d07c](googleapis/java-dms@296d07c)) * Update dependency importlib-metadata to v4.12.0 ([#278](googleapis/java-dms#278)) ([b4509fa](googleapis/java-dms@b4509fa)) * Update dependency jeepney to v0.8.0 ([#279](googleapis/java-dms#279)) ([b2b6e8f](googleapis/java-dms@b2b6e8f)) * Update dependency jinja2 to v3.1.2 ([#280](googleapis/java-dms#280)) ([c7c2a10](googleapis/java-dms@c7c2a10)) * Update dependency keyring to v23.9.3 ([#281](googleapis/java-dms#281)) ([981c58c](googleapis/java-dms@981c58c)) * Update dependency markupsafe to v2.1.1 ([#282](googleapis/java-dms#282)) ([5a78aa3](googleapis/java-dms@5a78aa3)) * Update dependency protobuf to v3.20.2 ([#283](googleapis/java-dms#283)) ([2444bcd](googleapis/java-dms@2444bcd)) * Update dependency protobuf to v4 ([#289](googleapis/java-dms#289)) ([b9e330a](googleapis/java-dms@b9e330a)) * Update dependency pyjwt to v2.5.0 ([#284](googleapis/java-dms#284)) ([9fc617d](googleapis/java-dms@9fc617d)) * Update dependency requests to v2.28.1 ([#285](googleapis/java-dms#285)) ([51574b4](googleapis/java-dms@51574b4)) * Update dependency typing-extensions to v4.3.0 ([#286](googleapis/java-dms#286)) ([c36d416](googleapis/java-dms@c36d416)) * Update dependency zipp to v3.8.1 ([#287](googleapis/java-dms#287)) ([34e4986](googleapis/java-dms@34e4986)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://togithub.com/googleapis/java-gsuite-addons/compare/v2.3.5...v2.3.6) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([14efe7d](https://togithub.com/googleapis/java-gsuite-addons/commit/14efe7d1ff861d4be6a79fa81549a188104b452d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Add null value (empty map) for blob metadata

333a3bb

mziccard added the api: storage Issues related to the Cloud Storage API. label Oct 22, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2015

mziccard added 3 commits October 22, 2015 15:06

Document patch behaviour in Blob and Storage javadoc

3b91741

Add integration test for replacing metadata

99178a3

Minor refactoring of ITStorageTest

04cf0a7

mziccard force-pushed the fix-unset-metadata branch from 380c5cc to 04cf0a7 Compare October 22, 2015 13:06

aozarov reviewed Oct 22, 2015
View reviewed changes

mziccard added 2 commits October 23, 2015 13:46

Use newHashMapWithExpectedSize instead of new HashMap

682848a

aozarov added a commit that referenced this pull request Oct 23, 2015

Merge pull request #279 from mziccard/fix-unset-metadata

33e932e

Provide a way to unset blob metadata

aozarov merged commit 33e932e into googleapis:master Oct 23, 2015

aozarov mentioned this pull request Oct 23, 2015

The result of a patch metadata is a union rather than replacement. #60

Closed

github-actions bot pushed a commit that referenced this pull request Jul 1, 2022

chore: release gapic-generator-java v1.0.11 (#279)

570d4a4

Committer: @miraleung PiperOrigin-RevId: 378266372 Source-Link: googleapis/googleapis@9e31055 Source-Link: googleapis/googleapis-gen@14629f6

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

chore: add native image checks as required (#279)

1a1bb5f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide a way to unset blob metadata #279

Provide a way to unset blob metadata #279

mziccard commented Oct 22, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Oct 22, 2015

mziccard commented Oct 22, 2015

Provide a way to unset blob metadata #279

Provide a way to unset blob metadata #279

Conversation

mziccard commented Oct 22, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Oct 22, 2015

mziccard commented Oct 22, 2015