Synchronize LocalResourceManagerHelper #497

ajkannan · 2015-12-21T21:31:32Z

Fix for #451

...ager/src/main/java/com/google/gcloud/resourcemanager/testing/LocalResourceManagerHelper.java

@@ -324,12 +322,9 @@ Response create(Project project) {
    }
  }

-  Response delete(String projectId) {
+  synchronized Response delete(String projectId) {


aozarov · 2015-12-22T00:33:24Z

Looks good to me. One suggestion that does not have any immediate benefit but could make future changes simpler. Feel free to merge as is if you like.

Synchronize LocalResourceManagerHelper

…oogleapis#497) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9

…g to v2.5.0 (#497) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-os-config](https://togithub.com/googleapis/java-os-config) | `2.4.3` -> `2.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-os-config/2.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-os-config/2.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-os-config/2.5.0/compatibility-slim/2.4.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-os-config/2.5.0/confidence-slim/2.4.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-os-config).

- [ ] Regenerate this pull request now. feat: support case insensitive match on search facets feat: allow disabling spell check in search requests feat: allow adding labels in search requests feat: allow returning min/max values on search numeric facets feat: allow using serving configs as an alias of placements feat: allow enabling recommendation filtering on custom attributes feat: return output BigQuery table on product / event export response feat: allow skiping default branch protection when doing product full import docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 464664497 Source-Link: googleapis/googleapis@c30c9cc Source-Link: googleapis/googleapis-gen@a7fe8d6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTdmZThkNjcyYjhjYmJhZGM1YWIzMjI1M2RlYTUwZTRjM2Q4ZTM5MCJ9 feat: support case insensitive match on search facets feat: allow to return min/max values on search numeric facets feat: allow to use serving configs as an alias of placements docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 464560246 Source-Link: googleapis/googleapis@139f56e Source-Link: googleapis/googleapis-gen@eca9b7e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWNhOWI3ZWNiZGMyYzY0YzJkMGVjMmU2Njg4ZjYzNTNhZmYxNjJlZiJ9 feat: support case insensitive match on search facets feat: allow disabling spell check in search requests feat: allow adding labels in search requests feat: allow returning min/max values on search numeric facets feat: allow using serving configs as an alias of placements feat: allow enabling recommendation filtering on custom attributes feat: return output BigQuery table on product / event export response docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 463980128 Source-Link: googleapis/googleapis@d6bce0e Source-Link: googleapis/googleapis-gen@e3d1296 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNkMTI5NmE5NTkyYjlmZTcxNGE3Y2JlOGQyYWNjNGJmNDJmNGVjMiJ9

🤖 I have created a release *beep* *boop* --- ## [2.4.0](googleapis/java-retail@v2.3.0...v2.4.0) (2022-08-09) ### Features * allow adding labels in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow adding labels in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow disabling spell check in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow disabling spell check in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow enabling recommendation filtering on custom attributes ([2be6d88](googleapis/java-retail@2be6d88)) * allow enabling recommendation filtering on custom attributes ([2be6d88](googleapis/java-retail@2be6d88)) * allow returning min/max values on search numeric facets ([2be6d88](googleapis/java-retail@2be6d88)) * allow returning min/max values on search numeric facets ([2be6d88](googleapis/java-retail@2be6d88)) * allow skiping default branch protection when doing product full import ([2be6d88](googleapis/java-retail@2be6d88)) * allow to return min/max values on search numeric facets ([2be6d88](googleapis/java-retail@2be6d88)) * allow to use serving configs as an alias of placements ([2be6d88](googleapis/java-retail@2be6d88)) * allow using serving configs as an alias of placements ([2be6d88](googleapis/java-retail@2be6d88)) * allow using serving configs as an alias of placements ([2be6d88](googleapis/java-retail@2be6d88)) * new model service to manage recommendation models ([#497](googleapis/java-retail#497)) ([2be6d88](googleapis/java-retail@2be6d88)) * return output BigQuery table on product / event export response ([2be6d88](googleapis/java-retail@2be6d88)) * return output BigQuery table on product / event export response ([2be6d88](googleapis/java-retail@2be6d88)) * support case insensitive match on search facets ([2be6d88](googleapis/java-retail@2be6d88)) * support case insensitive match on search facets ([2be6d88](googleapis/java-retail@2be6d88)) * support case insensitive match on search facets ([2be6d88](googleapis/java-retail@2be6d88)) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-retail/issues/1485)) ([#487](googleapis/java-retail#487)) ([ff6af57](googleapis/java-retail@ff6af57)) ### Documentation * keep the API doc up-to-date with recent changes ([2be6d88](googleapis/java-retail@2be6d88)) * keep the API doc up-to-date with recent changes ([2be6d88](googleapis/java-retail@2be6d88)) * keep the API doc up-to-date with recent changes ([2be6d88](googleapis/java-retail@2be6d88)) * **samples:** Refactoring product package (CRUD) ([#417](googleapis/java-retail#417)) ([d0c5f39](googleapis/java-retail@d0c5f39)) * **samples:** Refactoring search package ([#415](googleapis/java-retail#415)) ([f7e3b16](googleapis/java-retail@f7e3b16)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#499](googleapis/java-retail#499)) ([eb0b64d](googleapis/java-retail@eb0b64d)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#504](googleapis/java-retail#504)) ([38ffa21](googleapis/java-retail@38ffa21)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#507](googleapis/java-retail#507)) ([fdd05c6](googleapis/java-retail@fdd05c6)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#509](googleapis/java-retail#509)) ([05f2d9b](googleapis/java-retail@05f2d9b)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#510](googleapis/java-retail#510)) ([6dccbdf](googleapis/java-retail@6dccbdf)) * update dependency com.google.code.gson:gson to v2.9.1 ([#500](googleapis/java-retail#500)) ([4f864e8](googleapis/java-retail@4f864e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api:api-common](https://togithub.com/googleapis/api-common-java) | `2.2.1` -> `2.2.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.2/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.2/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/api-common-java</summary> ### [`v2.2.2`](https://togithub.com/googleapis/api-common-java/blob/HEAD/CHANGELOG.md#222-httpsgithubcomgoogleapisapi-common-javacomparev221v222-2022-08-04) ##### Dependencies - update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#364](https://togithub.com/googleapis/api-common-java/issues/364)) ([28ff65d](https://togithub.com/googleapis/api-common-java/commit/28ff65d7e70495cc079379b8e78cb515a2960dae)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).

Synchronize LocalResourceManagerHelper

12a10b5

ajkannan added testing api: cloudresourcemanager Issues related to the Resource Manager API. labels Dec 21, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2015

aozarov reviewed Dec 22, 2015
View reviewed changes

ajkannan added a commit that referenced this pull request Dec 22, 2015

Merge pull request #497 from ajkannan/synchronize-lrmh

62a2d71

Synchronize LocalResourceManagerHelper

ajkannan merged commit 62a2d71 into googleapis:master Dec 22, 2015

ajkannan deleted the synchronize-lrmh branch December 22, 2015 01:01

ajkannan mentioned this pull request Dec 22, 2015

Synchronize LocalResourceManagerHelper #451

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Synchronize LocalResourceManagerHelper #497

Synchronize LocalResourceManagerHelper #497

ajkannan commented Dec 21, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Dec 22, 2015

Synchronize LocalResourceManagerHelper #497

Synchronize LocalResourceManagerHelper #497

Conversation

ajkannan commented Dec 21, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Dec 22, 2015