Remove JobInfo hierarchy, add JobConfiguration hierarchy #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mziccard
force-pushed
the
bigquery-hierachies
branch
from
e0a6fec
to
84402ac
Compare
| } | ||
|
|
||
| /** | ||
| * Creates a builder for a BigQuery Load Configuration given the destination table and format. | ||
| */ | ||
| public static Builder builder(TableId destinationTable, FormatOptions format) { | ||
| return new Builder().destinationTable(destinationTable).formatOptions(format); | ||
| return new Builder<>().destinationTable(destinationTable).formatOptions(format); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Done withe the review. looks good. Main comment (as discussed verbally) is the suggestion to make JobConfiguration interface an abstract class (and use package scope methods to set or get from pb). |
mziccard
force-pushed
the
bigquery-hierachies
branch
from
022ad08
to
d170550
Compare
mziccard
force-pushed
the
bigquery-hierachies
branch
from
d170550
to
a2c8b39
Compare
| return job; | ||
| JobConfiguration configuration = job.configuration(); | ||
| JobInfo.Builder jobBuilder = job.toBuilder(); | ||
| switch (configuration.type()) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -200,7 +199,7 @@ public Builder toBuilder() { | |||
| } | |||
|
|
|||
| @Override | |||
| ToStringHelper toStringHelper() { | |||
| protected ToStringHelper toStringHelper() { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks great! Do you plan to do the same for BaseTableInfo ? BTW, looks like BigQueryException has 2 unused import statements. |
| private static final long serialVersionUID = -2673554846792429829L; | ||
|
|
||
| private final List<String> sourceUris; | ||
| protected final TableId destinationTable; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| private static final long serialVersionUID = 470267591917413578L; | ||
|
|
||
| protected final TableId destinationTable; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@aozarov Yes I plan to do a similar change to table's hierarchy but in a different PR as this is already big enough. |
aozarov
added a commit
that referenced
this pull request
Jan 29, 2016
Remove JobInfo hierarchy, add JobConfiguration hierarchy
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
…o v2.5.2 (#584) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-retail](https://togithub.com/googleapis/java-retail) ([source](https://togithub.com/googleapis/java-)) | `2.5.1` -> `2.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIxOS4xIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
JobInfohierarchy and replaces it with a hierarchy onJobConfiguration. This change is needed to make functionalJobextendJobInfo. Notes:CopyJobConfiguration,ExtractJobConfiguration,LoadJobConfigurationorQueryJobConfiguration) must be provided to create aJobInfoobject.LoadJobConfigurationalso extendsLoadConfigurationwhich is used for resumable uploadsJobConfigurationis an interface with only atype()method since configurations have no common data (this is also required to makeLoadJobConfigurationextendLoadConfiguration).