Docs, tests, and lint cleanup

[ajkannan]

This PR makes the following changes:

• Fixes indentation issues in all modules in code blocks in javadoc
• Fixes lint errors
• Fixes Move integration tests to different packages #580 (moves integration tests to separate package)
• Avoids reading extra output during local gcd shutdown.

[aozarov]

@mziccard That is great that you added codacy to gcloud-java and that we can see it in PR!!!

Any reason why the detail goes to https://www.codacy.com/app/mziccard/gcloud-java/pullRequest?prid=183606 (note the mziccard part of the URL)?

Also, is there a way to add a link-able image with some scoring based on codacy in our main README.md (like the one we have for coveralls)?

[mziccard]

@aozarov It goes to mziccard/... because I activated codacy for gcloud-java from my account. To have the URL point to GoogleCloudPlatform/... codacy should be activated by the owner/maintainer of the GoogleCloudPlatform account (I guess).

[aozarov]

@mziccard I see. We can stay with that for now. How did you make it be shown in the PR list? I also just created one for gcloud-java just to check the URL issue. does it mean that any one that created an codeacy project that is associated with gcloud-java will appear in this list?

BTW, did you tune the checkstyle/pmd settings for our needs? Is there a way for you to share those?

[mziccard]

@aozarov Actually, I have no idea. It seems a bit strange to me that all people that have access to the repository can create a different codacy project.

To make the PR status be shown I enabled that in codacy's "Integrations" settings. So if you do not enable it we should just receive one status notification. If you enable status notifications I have no clue what will happen.

I haven't tuned checkstyle/pmd settings. This is why I asked yesterday if you were able to access those settings. I meant if you have rights to access settings for "my" gcloud-java's codacy project (as occurs in travis for instance where all of us change settings as we have write access to the github's repo).

[aozarov]

Ah, no I don't have access to your settings or, more importantly, to "Code Patterns" Configuration.
However, I can see that they have an import/export option so maybe we can save the settings in gcloud-java. In that case feel free to do a first pass and then save it in gcloud-java and we can review it and modify if needed. Also, do you mind to add the badge?

[ajkannan]

@aozarov made the style fix mentioned above.

[aozarov]

@mziccard any reason the codacy reference disappeared from the list of checks?

[aozarov]

Looks good. One nit for unifying consecutive "{@code" sections.

[ajkannan]

Unified code sections

[mziccard]

@aozarov As you can see codacy checks did not disappear. They take some time to be run and hence the result takes some time to be displayed in the PR. I think the problem is that they are not triggered immediately after a commit. There's an option in "Settings" to set "the time to review a PR (hours) before receiving a notification", I set it to 0 which should make the review happen as fast as possible:

[aozarov]

Ah, BTW did you enabled the Post-Commit Hook and the 2 options for GitHub integration in the codacy settings?

[mziccard]

Yes. I enabled only the status option as comments are not necessary and messy