Bigquerystorage: fix missing dependency. #6736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6736 +/- ##
============================================
+ Coverage 46.37% 46.37% +<.01%
+ Complexity 28040 28025 -15
============================================
Files 2614 2614
Lines 288317 288317
Branches 33805 33810 +5
============================================
+ Hits 133711 133717 +6
+ Misses 144339 144335 -4
+ Partials 10267 10265 -2
Continue to review full report at Codecov.
|
elharo
suggested changes
Nov 12, 2019
google-cloud-bom/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-bigquerystorage</artifactId> | ||
| <version>0.118.1-beta-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquerystorage:current} --> |
There was a problem hiding this comment.
This shouldn't be a snapshot version and maybe not 0.118.1
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
athakor
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
added 2 commits
November 13, 2019 11:29
pmakani
force-pushed
the
api-bigquery-6710
branch
from
7df7eab
to
4a1ef41
Compare
|
@davidrabinowitz PTAL |
|
Great, thanks! |
|
@elharo PTAL. |
elharo
approved these changes
Nov 15, 2019
chingor13
approved these changes
Nov 25, 2019
This was referenced Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6710