Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate firestore to java-firestore #6808

Merged
merged 4 commits into from Nov 25, 2019
Merged

chore: migrate firestore to java-firestore #6808

merged 4 commits into from Nov 25, 2019

Conversation

BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Nov 18, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2019
@BenWhitehead BenWhitehead added api: firestore Issues related to the Firestore API. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 18, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2019
@BenWhitehead BenWhitehead marked this pull request as ready for review November 25, 2019 19:45
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving conflicts. Please make sure to migrate the newest version of the code.

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #6808 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6808      +/-   ##
============================================
- Coverage      55.6%   54.59%   -1.01%     
+ Complexity    10547     9566     -981     
============================================
  Files           774      712      -62     
  Lines         88523    83213    -5310     
  Branches       8080     7482     -598     
============================================
- Hits          49221    45431    -3790     
+ Misses        37083    35748    -1335     
+ Partials       2219     2034     -185
Impacted Files Coverage Δ Complexity Δ
.../cloud/datastore/testing/LocalDatastoreHelper.java 80.59% <0%> (-4.48%) 17% <0%> (ø)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.61% <0%> (-0.52%) 23% <0%> (ø)
...le/cloud/firestore/v1/stub/FirestoreAdminStub.java
...m/google/cloud/firestore/v1/FirestoreSettings.java
...loud/firestore/v1beta1/stub/GrpcFirestoreStub.java
...cloud/firestore/v1/stub/FirestoreStubSettings.java
.../firestore/v1/stub/FirestoreAdminStubSettings.java
.../firestore/v1beta1/stub/FirestoreStubSettings.java
...e/cloud/firestore/collection/LLRBRedValueNode.java
...oogle/cloud/firestore/spi/v1/GrpcFirestoreRpc.java
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6427235...7d53b72. Read the comment docs.

@BenWhitehead
Copy link
Contributor Author

Thanks @schmidt-sebastian! I've rebased and pushed.

The code over in java-firestore is up-to-date as of the MR I merged a little while ago.

@BenWhitehead BenWhitehead merged commit b1c97a2 into googleapis:master Nov 25, 2019
@BenWhitehead BenWhitehead deleted the migrate-firestore branch November 25, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants