Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract clients to split repositories #6894

Merged
merged 25 commits into from Nov 25, 2019
Merged

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Nov 25, 2019

Does not include bigtable, firestore, or pubsub yet.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2019
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #6894 into master will decrease coverage by 8.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6894      +/-   ##
============================================
- Coverage     53.89%   45.28%   -8.62%     
+ Complexity     9096     6249    -2847     
============================================
  Files           712      453     -259     
  Lines         81282    56280   -25002     
  Branches       7307     7229      -78     
============================================
- Hits          43809    25484   -18325     
+ Misses        35521    29138    -6383     
+ Partials       1952     1658     -294
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 89.58% <0%> (-1.91%) 32% <0%> (ø)
...eas/src/main/java/io/grafeas/v1/GrafeasClient.java 61.63% <0%> (-1.47%) 59% <0%> (+14%)
...anner/jdbc/ClientSideStatementValueConverters.java 92.22% <0%> (-1.04%) 0% <0%> (ø)
...ogle/cloud/spanner/jdbc/ReadOnlyStalenessUtil.java 70.27% <0%> (-0.97%) 25% <0%> (ø)
...le/cloud/spanner/jdbc/JdbcSqlExceptionFactory.java 45.71% <0%> (-0.67%) 7% <0%> (ø)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.61% <0%> (-0.52%) 23% <0%> (ø)
...ery/datatransfer/v1/DataTransferServiceClient.java 65.35% <0%> (-0.51%) 55% <0%> (+13%)
...e/cloud/bigquery/testing/RemoteBigQueryHelper.java 61.4% <0%> (-0.42%) 6% <0%> (ø)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 58.76% <0%> (-0.4%) 70% <0%> (+16%)
...ava/com/google/cloud/pubsub/v1/OpenCensusUtil.java 71.42% <0%> (-0.24%) 5% <0%> (ø)
... and 410 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c97a2...8efa34a. Read the comment docs.

@chingor13 chingor13 requested a review from a team November 25, 2019 22:09
@chingor13 chingor13 merged commit 005a8e3 into googleapis:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants