spanner-jdbc: Include shaded jar in standard build and publish to Maven Central #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the shaded Spanner JDBC jar in the standard build for the library and publish it to Maven central with a classifier. This makes the shaded jar downloadable directly from Maven, instead of requiring users to build the jar themselves. Fixes #6950.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6957 +/- ##
============================================
- Coverage 41.05% 41.04% -0.01%
+ Complexity 5290 5289 -1
============================================
Files 360 360
Lines 50413 50413
Branches 6913 6913
============================================
- Hits 20695 20693 -2
- Misses 28243 28244 +1
- Partials 1475 1476 +1
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Dec 11, 2019
| <!-- Profile for building a jar containing all dependencies and the | ||
| JDBC driver. This jar can then be used with third-party tools that support | ||
| generic JDBC drivers to connect to Cloud Spanner databases. --> | ||
| <id>build-jdbc-driver</id> |
There was a problem hiding this comment.
I'm a bit unsure why this is removed.
|
Moved to new repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the shaded Spanner JDBC jar in the standard build for the library and publish it to Maven central with a classifier. This makes the shaded jar downloadable directly from Maven, instead of requiring users to build the jar themselves.
Fixes #6950.