Add disableGzipContent option for create from InputStream #7057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only the methods to create blobs that take a byte[] argument offer the option to disable gzip compression; the methods that accept an InputStream argument do not. This is due to the BlobWriteOption enum missing a matching constant for BlobTargetOption.IF_DISABLE_GZIP_CONTENT. This change set adds a matching IF_DISABLE_GZIP_CONTENT constant to BlobWriteOption including the correct translation to StorageRpc.Option. The net result is that the Storage create functions that accept an InputStream now offer the option to disable gzip compression.
googlebot
added
the
cla: yes
athakor
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #7057 +/- ##
============================================
- Coverage 32.18% 32.18% -0.01%
+ Complexity 3698 3697 -1
============================================
Files 249 249
Lines 40371 40373 +2
Branches 6134 6134
============================================
Hits 12994 12994
- Misses 26304 26305 +1
- Partials 1073 1074 +1
Continue to review full report at Codecov.
|
nblair
commented
Dec 19, 2019
| @@ -699,6 +700,10 @@ public static BlobWriteOption kmsKeyName(String kmsKeyName) { | |||
| public static BlobWriteOption userProject(String userProject) { | |||
| return new BlobWriteOption(Option.USER_PROJECT, userProject); | |||
| } | |||
|
|
|||
| public static BlobWriteOption disableGzipContent() { | |||
There was a problem hiding this comment.
Is a javadoc desired here? If so, what do you think of the text:
Returns an option that signals automatic gzip compression should not be performed en route to the bucket.
|
closing this PR as it's already merged in respective repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the methods to create blobs that take a
byte[]argument offer the option to disable gzip compression; the methods that accept anInputStreamargument do not. This is due to theBlobWriteOptionenum missing a matching constant forBlobTargetOption.IF_DISABLE_GZIP_CONTENT.This change set adds a matching
IF_DISABLE_GZIP_CONTENTconstant toBlobWriteOptionincluding the correct translation to StorageRpc.Option. The net result is that the Storage create functions that accept an InputStream now offer the option to disable gzip compression.Fixes #7056.