Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migration datastore to java-datastore #7063

Merged
merged 4 commits into from Dec 20, 2019
Merged

chore: migration datastore to java-datastore #7063

merged 4 commits into from Dec 20, 2019

Conversation

BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead requested a review from a team December 20, 2019 21:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2019
codyoss
codyoss approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let make sure to make the backend kokoro change to stop this integration test

@BenWhitehead BenWhitehead merged commit 6138a96 into googleapis:master Dec 20, 2019
@BenWhitehead BenWhitehead deleted the datastore/post-migration branch December 20, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenWhitehead @codyoss @kolea2 @googlebot